GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — lock-free init_process_flags for all archs by kapouer · Pull Request #45221 · nodejs/node

Conversation

kapouer commented Oct 28, 2022

Copy link

Copy Markdown

Contributor

Fix #45152

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction

nodejs-github-bot commented Oct 28, 2022

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/startup

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci PRs that need a full CI run. labels

Oct 28, 2022

kapouer force-pushed the patch-4 branch from a35ba7e to d94edb8 Compare

October 28, 2022 09:32

addaleax reviewed

Oct 28, 2022

View reviewed changes

Comment thread

src/node.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

kapouer force-pushed the patch-4 branch from d94edb8 to 2fc42b0 Compare

October 28, 2022 12:52

addaleax requested changes

Oct 28, 2022

View reviewed changes

Comment thread

src/node.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/node.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

kapouer force-pushed the patch-4 branch 2 times, most recently from 2fc42b0 to 1627557 Compare

October 28, 2022 13:19

addaleax approved these changes

Oct 28, 2022

View reviewed changes

addaleax added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 28, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 28, 2022

This comment was marked as outdated.


          src: lock-free init_process_flags

212d228

Fix nodejs#45152

kapouer force-pushed the patch-4 branch from d6147ca to 212d228 Compare

October 28, 2022 13:39

kapouer commented Oct 28, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

@addaleax changed TODO(addaleax) and wrapped line to 80 chars.

addaleax reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 28, 2022

addaleax approved these changes

Oct 28, 2022

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 28, 2022

This comment was marked as outdated.

juanarbol approved these changes

Oct 28, 2022

View reviewed changes

This comment was marked as outdated.

This was referenced Oct 29, 2022

CI Reliability 2022-10-29 nodejs/reliability#414

Open

CI Reliability 2022-10-30 nodejs/reliability#415

Open

CI Reliability 2022-10-31 nodejs/reliability#416

Open

Flarna approved these changes

Oct 31, 2022

View reviewed changes

nodejs-github-bot commented Oct 31, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47593/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Flarna added author ready

PRs with CI started, the required approvals, and no outstanding review comments.

commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels

Oct 31, 2022

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 31, 2022

nodejs-github-bot merged commit 3d1bdc9 into nodejs:main

Oct 31, 2022

nodejs-github-bot commented Oct 31, 2022

Copy link

Copy Markdown

Collaborator

Landed in 3d1bdc9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Nov 1, 2022

CI Reliability 2022-11-01 nodejs/reliability#417

Open

17 tasks

RafaelGSS pushed a commit that referenced this pull request

Nov 1, 2022


          src: lock-free init_process_flags

db81931

Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>

RafaelGSS mentioned this pull request

Nov 1, 2022

v19.1.0 proposal #45269

Merged

github-actions Bot mentioned this pull request

Nov 2, 2022

CI Reliability 2022-11-02 nodejs/reliability#418

Open

15 tasks

RafaelGSS pushed a commit that referenced this pull request

Nov 10, 2022


          src: lock-free init_process_flags

97547bc

Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>

danielleadams mentioned this pull request

Dec 30, 2022

v18.13.0 release proposal #46025

Merged

danielleadams pushed a commit that referenced this pull request

Dec 30, 2022


          src: lock-free init_process_flags

8247d10

Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>

danielleadams pushed a commit that referenced this pull request

Jan 3, 2023


          src: lock-free init_process_flags

bf028a6

Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>

addaleax mentioned this pull request

Jan 30, 2023

src: use uint32_t for process initialization flags enum #46427

Merged

addaleax added a commit to addaleax/node that referenced this pull request

Jan 30, 2023


          src: use uint32_t for process initialization flags enum

f3cffbd

Refs: nodejs#45221

nodejs-github-bot pushed a commit that referenced this pull request

Feb 2, 2023


          src: use uint32_t for process initialization flags enum

f84de0a

Refs: #45221
PR-URL: #46427
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

Reviewers

addaleax

addaleax approved these changes

juanarbol

juanarbol approved these changes

Flarna

Flarna approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

c++

Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

init_process_flags.is_lock_free check fails on mipsel

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

kapouer commented Oct 28, 2022

Uh oh!

nodejs-github-bot commented Oct 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

kapouer commented Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Oct 31, 2022

Uh oh!

nodejs-github-bot commented Oct 31, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kapouer commented Oct 28, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.