GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: update AUTHORS by nodejs-github-bot · Pull Request #45238 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Oct 30, 2022

Copy link
Copy Markdown
Collaborator

Here are some new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.mjs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot
meta: update AUTHORS
90a6712
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 30, 2022
@aduh95

aduh95 commented Oct 30, 2022

Copy link
Copy Markdown
Contributor 
Author name already in AUTHORS file. Possible duplicate:
  Vladimir Morozov <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Andreas Schwab <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Brian Muenzenmeyer <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Steven R. Loomis <[email protected]>

https://github.com/nodejs/node/actions/runs/3353516963/jobs/5556361773#step:3:6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
fixup! meta: update AUTHORS
7b59846
@Trott

Trott commented Oct 30, 2022

Copy link
Copy Markdown
Member 
Author name already in AUTHORS file. Possible duplicate:
  Vladimir Morozov <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Andreas Schwab <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Brian Muenzenmeyer <[email protected]>
Author name already in AUTHORS file. Possible duplicate:
  Steven R. Loomis <[email protected]>

https://github.com/nodejs/node/actions/runs/3353516963/jobs/5556361773#step:3:6

Confirmed that they were all duplicates (by looking at commits in the log file for both email addresses for each name, going to the PR-URL, and confirming that it was the same GitHub username for both email addresses), added .mailmap entries, and reran tools/update-authors.mjs. Should be ready to land.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 30, 2022
Trott
Trott approved these changes Oct 30, 2022
View reviewed changes
Trott
Trott approved these changes Oct 30, 2022
View reviewed changes
lpinca
lpinca approved these changes Oct 30, 2022
View reviewed changes
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 30, 2022
@github-actions

github-actions Bot commented Oct 30, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 30, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 2364ed7 into main Oct 30, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 30, 2022

Copy link
Copy Markdown
Collaborator Author

Landed in 2364ed7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot
nodejs-github-bot deleted the actions/authors-update branch October 30, 2022 15:06
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@nodejs-github-bot @RafaelGSS
meta: update AUTHORS
65f3c61 
PR-URL: #45238
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@nodejs-github-bot @RafaelGSS
meta: update AUTHORS
b41b5ba 
PR-URL: #45238
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nodejs-github-bot @danielleadams
meta: update AUTHORS
8bcc87c 
PR-URL: #45238
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@nodejs-github-bot @danielleadams
meta: update AUTHORS
d7fe2ea 
PR-URL: #45238
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@nodejs-github-bot @aduh95 @Trott @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.