GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: protect fs.watch from monkeypatches by anonrig · Pull Request #45265 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Nov 1, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Follow up on comments from #45098

CC @nodejs/fs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
anonrig added 2 commits November 1, 2022 09:51
@anonrig
fs: update todo message
0fc80d2
@anonrig
fs: protect fs.watch from monkeypatches
1673db4
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Nov 1, 2022
@anonrig anonrig mentioned this pull request Nov 1, 2022
fs: add recursive watch for linux #45098
Merged
5 tasks done
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 1, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 1, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47617/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95
aduh95 approved these changes Nov 1, 2022
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 1, 2022
@anonrig anonrig added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 1, 2022
@github-actions

github-actions Bot commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

RafaelGSS, MoLow, and Uzlopak reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS
RafaelGSS approved these changes Nov 1, 2022
View reviewed changes
MoLow
MoLow approved these changes Nov 1, 2022
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 1, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 1, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45265
✔  Done loading data for nodejs/node/pull/45265
----------------------------------- PR info ------------------------------------
Title      fs: protect fs.watch from monkeypatches (#45265)
Author     Yagiz Nizipli  (@anonrig)
Branch     anonrig:fs/recursive-followup -> nodejs:main
Labels     fs, fast-track, author ready, needs-ci
Commits    2
 - fs: update todo message
 - fs: protect fs.watch from monkeypatches
Committers 1
 - Yagiz Nizipli 
PR-URL: https://github.com/nodejs/node/pull/45265
Reviewed-By: Antoine du Hamel 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45265
Reviewed-By: Antoine du Hamel 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 01 Nov 2022 13:52:48 GMT
   ✔  Approvals: 3
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45265#pullrequestreview-1163697719
   ✔  - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/45265#pullrequestreview-1163772612
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45265#pullrequestreview-1163822822
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-01T13:59:09Z: https://ci.nodejs.org/job/node-test-pull-request/47617/
- Querying data for job/node-test-pull-request/47617/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 45265
From https://github.com/nodejs/node
 * branch                  refs/pull/45265/merge -> FETCH_HEAD
✔  Fetched commits as acd6f6c6082f..1673db412c4b
--------------------------------------------------------------------------------
[main 1e03c3af54] fs: update todo message
 Author: Yagiz Nizipli 
 Date: Tue Nov 1 09:51:49 2022 -0400
 2 files changed, 2 insertions(+), 2 deletions(-)
[main d1b8cb5ca8] fs: protect fs.watch from monkeypatches
 Author: Yagiz Nizipli 
 Date: Tue Nov 1 09:52:19 2022 -0400
 1 file changed, 14 insertions(+), 9 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fs: update todo message

PR-URL: #45265
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Moshe Atlow [email protected]

[detached HEAD 517608ead3] fs: update todo message
Author: Yagiz Nizipli [email protected]
Date: Tue Nov 1 09:51:49 2022 -0400
2 files changed, 2 insertions(+), 2 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fs: protect fs.watch from monkeypatches

PR-URL: #45265
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Moshe Atlow [email protected]

[detached HEAD ab4b72a62d] fs: protect fs.watch from monkeypatches
Author: Yagiz Nizipli [email protected]
Date: Tue Nov 1 09:52:19 2022 -0400
1 file changed, 14 insertions(+), 9 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/3371785169

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anonrig anonrig added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Nov 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 1, 2022
@nodejs-github-bot
nodejs-github-bot merged commit a5c6f3e into nodejs:main Nov 1, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator

Landed in a5c6f3e

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS

RafaelGSS commented Nov 1, 2022

Copy link
Copy Markdown
Member

@anonrig fyi the commit title looks confusing a5c6f3e

it was squashed and used the last commit as main title

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@anonrig @RafaelGSS
fs: update todo message
e9e2b27
PR-URL: #45265
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@anonrig

anonrig commented Nov 2, 2022

Copy link
Copy Markdown
Member Author

Yes @RafaelGSS. This was an educational experience for me. Sorry for the disturbance (and future ones) I've caused. It seems squash gets the first commit title. I thought it was the pull requests title. In this scenario, does the pull request require node-core-utils intervention to select the correct commit message for squash? Is there an automated way of selecting the squash title using labels?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@anonrig @RafaelGSS
fs: update todo message
daff3b8
PR-URL: #45265
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
v19.1.0 proposal #45269
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig @danielleadams
fs: update todo message
8f2e9fe
PR-URL: #45265
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@anonrig @danielleadams
fs: update todo message
c2f0377
PR-URL: #45265
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. fast-track PRs proposed for a shorter-than-standard waiting period before landing. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@anonrig @nodejs-github-bot @RafaelGSS @MoLow @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.