GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — diagnostics_channel: mark as stable by Qard · Pull Request #45290 · nodejs/node

Conversation

Qard commented Nov 2, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

I'm proposing that we mark diagnostics_channel as stable. It has been used extensively in the Datadog tracer for awhile now and we're quite satisfied that it serves the intended purpose. Marking as stable will help significantly with pushing for ecosystem adoption in the future.

cc @nodejs/diagnostics

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction

Qard added diag-agenda

Issues and PRs to discuss during Diagnostics Working Group meetings.

diagnostics_channel Issues and PRs related to the diagnostics_channel module. labels

Nov 2, 2022

nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label

Nov 2, 2022

Flarna approved these changes

Nov 2, 2022

View reviewed changes

Flarna left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the version in the doc metadata when it was moved to stable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

lpinca approved these changes

Nov 2, 2022

View reviewed changes

Qard commented Nov 2, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

@Flarna Do we have an example of that in our existing docs? I did a search when I made this and found nothing, which was a bit surprising to me actually. 🤔

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell approved these changes

Nov 2, 2022

View reviewed changes

santigimeno approved these changes

Nov 2, 2022

View reviewed changes

Flarna commented Nov 3, 2022

Copy link

Copy Markdown

Member

I found it e.g. in HTTP2.

Use REPLACEME for the version itself as far as I know, see https://github.com/nodejs/node/blob/1af63a90ca3a59ca05b3a12ad7dbea04008db7d9/doc/contributing/pull-requests.md#step-3-code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Qard commented Nov 3, 2022

Copy link

Copy Markdown

Member Author

If you're referring to the "added" field, that's for when the feature was added, not for when it was stabilized. I searched the docs and all I could find was "added" and "deprecated" fields in the YAML front-matter. As far as I can tell there is no stabilization version field. 🤔

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Flarna commented Nov 3, 2022

Copy link

Copy Markdown

Member

The HTTP 2 entry has the following which seems to be similar then this here:

- version: v10.10.0
    pr-url: https://github.com/nodejs/node/pull/22466
    description: HTTP/2 is now Stable. Previously, it had been Experimental.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS approved these changes

Nov 3, 2022

View reviewed changes

RafaelGSS left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

anonrig approved these changes

Nov 3, 2022

View reviewed changes

tony-go approved these changes

Nov 3, 2022

View reviewed changes


          diagnostics_channel: mark as stable

9d8e285

Qard force-pushed the stabilize-diagnostics-channel branch from 23496a7 to 9d8e285 Compare

November 3, 2022 23:02

Qard commented Nov 3, 2022

Copy link

Copy Markdown

Member Author

Updated with changes list to document the version at which the stabilization occurs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Flarna approved these changes

Nov 3, 2022

View reviewed changes

legendecas approved these changes

Nov 4, 2022

View reviewed changes

gireeshpunathil approved these changes

Nov 4, 2022

View reviewed changes

Qard added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed diag-agenda Issues and PRs to discuss during Diagnostics Working Group meetings. labels

Nov 4, 2022

github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Nov 4, 2022

github-actions Bot commented Nov 4, 2022

Copy link

Copy Markdown

Contributor

Failed to start CI

- Validating Jenkins credentials
✖  Jenkins credentials invalid

https://github.com/nodejs/node/actions/runs/3396629140

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Qard added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels

Nov 4, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 4, 2022

nodejs-github-bot commented Nov 4, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47683/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 4, 2022

nodejs-github-bot commented Nov 5, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47703/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Flarna added the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 5, 2022

Flarna commented Nov 5, 2022

Copy link

Copy Markdown

Member

@Qard for doc only changes GitHub ci would be enough.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 5, 2022

nodejs-github-bot merged commit 2db03a6 into nodejs:main

Nov 5, 2022

nodejs-github-bot commented Nov 5, 2022

Copy link

Copy Markdown

Collaborator

Landed in 2db03a6

Qard reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Qard deleted the stabilize-diagnostics-channel branch

November 5, 2022 18:53

This was referenced Nov 6, 2022

CI Reliability 2022-11-06 nodejs/reliability#420

Open

CI Reliability 2022-11-07 nodejs/reliability#421

Open

CI Reliability 2022-11-08 nodejs/reliability#422

Open

Flarna mentioned this pull request

Nov 10, 2022

Stability of built in diagnostics channels #45400

Closed

Flarna commented Nov 10, 2022

Copy link

Copy Markdown

Member

I just noticed that this moved not only the diag channel API to stable but also the built in channels. I'm not sure if this was intended. Created #45400 to discuss this further.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Qard commented Nov 10, 2022

Copy link

Copy Markdown

Member Author

No, channels themselves are not stable and are not intended to be considered stable in the future. They are an informational source that is meant to be treated as optional. You can subscribe to a named channel but may or may not ever receive events from that channel.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Flarna added the dont-land-on-v19.x label

Nov 10, 2022

Flarna commented Nov 10, 2022

Copy link

Copy Markdown

Member

I added the dont-land-on-v19 label until #45400 is resolved.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Flarna removed the dont-land-on-v19.x label

Nov 15, 2022

ruyadorno pushed a commit that referenced this pull request

Nov 21, 2022


          diagnostics_channel: mark as stable

44886e5

PR-URL: #45290
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>

ruyadorno mentioned this pull request

Nov 24, 2022

v19.2.0 proposal #45615

Merged

danielleadams mentioned this pull request

Dec 30, 2022

v18.13.0 release proposal #46025

Merged

danielleadams pushed a commit that referenced this pull request

Dec 30, 2022


          diagnostics_channel: mark as stable

f496708

PR-URL: #45290
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>

danielleadams pushed a commit that referenced this pull request

Jan 3, 2023


          diagnostics_channel: mark as stable

2752f54

PR-URL: #45290
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>

logaretm mentioned this pull request

Jul 15, 2026

diagnostics_channel: mark TracingChannel as stable #64525

Closed

logaretm added a commit to logaretm/node that referenced this pull request

Jul 15, 2026


          diagnostics_channel: mark TracingChannel as stable

e445b63

Promotes the diagnostics_channel.tracingChannel() factory and the
TracingChannel class from experimental to stable.

TracingChannel has been available since v18.19.0 / v19.9.0 with an
unchanged surface and now has broad adoption: fastify, pino, mysql2,
redis, ioredis, mongoose, graphql, h3, srvx, and the Vercel AI SDK
publish TracingChannel events natively, and it is consumed by
OpenTelemetry, Sentry, Datadog, and New Relic. The last behavioral
wart, tracePromise stripping custom thenables (nodejs#59936), was resolved
in nodejs#61766.

This mirrors the scoping in nodejs#45290: BoundedChannel, the bindStore /
runStores store helpers, and the concrete built-in channels stay
experimental.

Signed-off-by: Abdelrahman Awad <[email protected]>

avivkeller pushed a commit that referenced this pull request

Aug 10, 2026


          diagnostics_channel: mark TracingChannel as stable

d512d2d

Promotes the diagnostics_channel.tracingChannel() factory and the
TracingChannel class from experimental to stable.

TracingChannel has been available since v18.19.0 / v19.9.0 with an
unchanged surface and now has broad adoption: fastify, pino, mysql2,
redis, ioredis, mongoose, graphql, h3, srvx, and the Vercel AI SDK
publish TracingChannel events natively, and it is consumed by
OpenTelemetry, Sentry, Datadog, and New Relic. The last behavioral
wart, tracePromise stripping custom thenables (#59936), was resolved
in #61766.

This mirrors the scoping in #45290: BoundedChannel, the bindStore /
runStores store helpers, and the concrete built-in channels stay
experimental.

Signed-off-by: Abdelrahman Awad <[email protected]>
PR-URL: #64525
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>

aduh95 pushed a commit that referenced this pull request

Aug 13, 2026


          diagnostics_channel: mark TracingChannel as stable

a316b44

Promotes the diagnostics_channel.tracingChannel() factory and the
TracingChannel class from experimental to stable.

TracingChannel has been available since v18.19.0 / v19.9.0 with an
unchanged surface and now has broad adoption: fastify, pino, mysql2,
redis, ioredis, mongoose, graphql, h3, srvx, and the Vercel AI SDK
publish TracingChannel events natively, and it is consumed by
OpenTelemetry, Sentry, Datadog, and New Relic. The last behavioral
wart, tracePromise stripping custom thenables (#59936), was resolved
in #61766.

This mirrors the scoping in #45290: BoundedChannel, the bindStore /
runStores store helpers, and the concrete built-in channels stay
experimental.

Signed-off-by: Abdelrahman Awad <[email protected]>
PR-URL: #64525
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>

aduh95 pushed a commit that referenced this pull request

Aug 25, 2026


          diagnostics_channel: mark TracingChannel as stable

3f4b80e

Promotes the diagnostics_channel.tracingChannel() factory and the
TracingChannel class from experimental to stable.

TracingChannel has been available since v18.19.0 / v19.9.0 with an
unchanged surface and now has broad adoption: fastify, pino, mysql2,
redis, ioredis, mongoose, graphql, h3, srvx, and the Vercel AI SDK
publish TracingChannel events natively, and it is consumed by
OpenTelemetry, Sentry, Datadog, and New Relic. The last behavioral
wart, tracePromise stripping custom thenables (#59936), was resolved
in #61766.

This mirrors the scoping in #45290: BoundedChannel, the bindStore /
runStores store helpers, and the concrete built-in channels stay
experimental.

Signed-off-by: Abdelrahman Awad <[email protected]>
PR-URL: #64525
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>

Reviewers

jasnell

jasnell approved these changes

santigimeno

santigimeno approved these changes

lpinca

lpinca approved these changes

anonrig

anonrig approved these changes

gireeshpunathil

gireeshpunathil approved these changes

legendecas

legendecas approved these changes

Flarna

Flarna approved these changes

RafaelGSS

RafaelGSS approved these changes

+1 more reviewer

tony-go

tony-go approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

diagnostics_channel

Issues and PRs related to the diagnostics_channel module.

doc

Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Qard commented Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flarna left a comment

Choose a reason for hiding this comment

Uh oh!

Qard commented Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flarna commented Nov 3, 2022

Uh oh!

Qard commented Nov 3, 2022

Uh oh!

Flarna commented Nov 3, 2022

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

Qard commented Nov 3, 2022

Uh oh!

github-actions Bot commented Nov 4, 2022

Uh oh!

nodejs-github-bot commented Nov 4, 2022

Uh oh!

nodejs-github-bot commented Nov 5, 2022

Uh oh!

Flarna commented Nov 5, 2022

Uh oh!

nodejs-github-bot commented Nov 5, 2022

Uh oh!

Flarna commented Nov 10, 2022

Uh oh!

Qard commented Nov 10, 2022

Uh oh!

Flarna commented Nov 10, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Qard commented Nov 2, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Qard commented Nov 2, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.