GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: add GitHub token permissions to label flaky-test issues by gabibguti · Pull Request #45308 · nodejs/node

Conversation

@gabibguti

@gabibguti gabibguti commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Add minimum GITHUB_TOKEN permissions for label-flaky-test-issue.yml workflow.

Motivation: Setting minimum permissions on workflow's top level is good practice. Similar changes were previously discussed in #43743. Since label flaky-test issues workflow was recently added, this PR is a small update to restrict it's permissions.

About me: I'm Gabriela and I work on behalf of Google and the OpenSSF suggesting supply-chain security changes :)

Signed-off-by: Gabriela Gutierrez [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gabibguti
tools: add GitHub token permissions to label flaky-test issues
a77270c 
Signed-off-by: Gabriela Gutierrez <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Nov 3, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 3, 2022
@aduh95

aduh95 commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Is read permission actually enough for labelling issues? That seems quite counter intuitive to me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gabibguti

gabibguti commented Nov 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Is read permission actually enough for labelling issues? That seems quite counter intuitive to me.

No, you are right, it is not. The permission that allows labelling the issues is issues: write inside the job in line 12 of the unchanged file.

The contents: read permission before the job is to avoid this job and other jobs from "by default" being able to access the contents of the repository. Access to the contents of the repository means being able to create files, delete files, among other things.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
lpinca
lpinca approved these changes Dec 3, 2022
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 4, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 4, 2022
@nodejs-github-bot
nodejs-github-bot merged commit de696d7 into nodejs:main Dec 4, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator

Landed in de696d7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gabibguti
gabibguti deleted the workflow-permissions branch December 6, 2022 17:59
targos pushed a commit that referenced this pull request Dec 12, 2022
@gabibguti @targos
tools: add GitHub token permissions to label flaky-test issues
324ae3d 
Signed-off-by: Gabriela Gutierrez <[email protected]>
PR-URL: #45308
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Dec 12, 2022
v19.3.0 release proposal #45831
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@gabibguti @danielleadams
tools: add GitHub token permissions to label flaky-test issues
94286fe 
Signed-off-by: Gabriela Gutierrez <[email protected]>
PR-URL: #45308
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@gabibguti @danielleadams
tools: add GitHub token permissions to label flaky-test issues
aa57f6c 
Signed-off-by: Gabriela Gutierrez <[email protected]>
PR-URL: #45308
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@gabibguti @danielleadams
tools: add GitHub token permissions to label flaky-test issues
12c100c 
Signed-off-by: Gabriela Gutierrez <[email protected]>
PR-URL: #45308
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gabibguti @nodejs-github-bot @aduh95 @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.