GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — crypto: handle unsupported AES ciphers in webcrypto by panva · Pull Request #45321 · nodejs/node

Conversation

@panva

@panva panva commented Nov 4, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This fixes Electron's exit (and other runtimes that embed Node.js?) caused by missing ciphers due to use of BoringSSL.

Refs: electron/electron#36256

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@panva
crypto: handle unsupported AES ciphers in webcrypto
9c56de3 
Refs: electron/electron#36256
@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto Issues and PRs related to the Web Crypto API. labels Nov 4, 2022
@panva
panva requested a review from jasnell November 4, 2022 23:34
@nodejs-github-bot

nodejs-github-bot commented Nov 4, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 4, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 4, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 4, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 approved these changes Nov 5, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47710/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 5, 2022
daeyeon
daeyeon approved these changes Nov 5, 2022
View reviewed changes
addaleax
addaleax approved these changes Nov 5, 2022
View reviewed changes
tniessen
tniessen approved these changes Nov 6, 2022
View reviewed changes
codebytere
codebytere approved these changes Nov 6, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Nov 7, 2022
CI Reliability 2022-11-07 nodejs/reliability#421
Open
18 tasks
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 7, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 0d7a139 into nodejs:main Nov 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator

Landed in 0d7a139
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva
panva deleted the webcrypto-fix-unsupported-cipher-exit branch November 7, 2022 06:54
@github-actions github-actions Bot mentioned this pull request Nov 8, 2022
CI Reliability 2022-11-08 nodejs/reliability#422
Open
17 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@panva @RafaelGSS
crypto: handle unsupported AES ciphers in webcrypto
13fb05e 
Refs: electron/electron#36256
PR-URL: #45321
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
v19.1.0 proposal #45269
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: handle unsupported AES ciphers in webcrypto
0e2f0a5 
Refs: electron/electron#36256
PR-URL: #45321
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
crypto: handle unsupported AES ciphers in webcrypto
b54f876 
Refs: electron/electron#36256
PR-URL: #45321
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@codebytere codebytere codebytere approved these changes
@tniessen tniessen tniessen approved these changes
@daeyeon daeyeon daeyeon approved these changes
@aduh95 aduh95 aduh95 approved these changes
@jasnell jasnell Awaiting requested review from jasnell

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@panva @nodejs-github-bot @addaleax @codebytere @tniessen @daeyeon @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.