GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: skip test-fs-largefile if not enough disk space by Trott · Pull Request #45339 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 6, 2022

Copy link
Copy Markdown
Member

Fixes: nodejs/build#3071

I'm guessing this is the test that then causes other cascading disk failures, but maybe there are others. Let's run CI here and find out....

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 6, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 6, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47736/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

My Jenkins CI didn't run out of space so I'm running just the macOS part of it again. I want to see that the test is actually skipped when ENOSPC happens. https://ci.nodejs.org/job/node-test-commit-osx/48467/

EDIT: And another one. https://ci.nodejs.org/job/node-test-commit-osx/48469/

EDIT: And one more. https://ci.nodejs.org/job/node-test-commit-osx/48470/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 7, 2022

Copy link
Copy Markdown
Member Author

Here's another one: https://ci.nodejs.org/job/node-test-commit-osx/48483/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47751/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 7, 2022
CI Reliability 2022-11-07 nodejs/reliability#421
Open
18 tasks
@Trott

Trott commented Nov 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Hooray, it caught a failure that time!

https://ci.nodejs.org/job/node-test-commit-osx/48483/nodes=osx1015/console

image

I think this is ready for review and landing.

@anonrig @nodejs/testing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Nov 7, 2022
View reviewed changes

@anonrig anonrig left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks @Trott. Can you apply the same changes to other tests too?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 7, 2022
Linkgoron
Linkgoron approved these changes Nov 7, 2022
View reviewed changes
@anonrig anonrig added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 7, 2022
@github-actions

github-actions Bot commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.
anonrig and Linkgoron reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 7, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45339
✔  Done loading data for nodejs/node/pull/45339
----------------------------------- PR info ------------------------------------
Title      test: skip test-fs-largefile if not enough disk space (#45339)
Author     Rich Trott  (@Trott)
Branch     Trott:fix-fs -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: skip test-fs-largefile if not enough disk space
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 06 Nov 2022 15:55:11 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169721564
   ✔  - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169894956
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-07T00:01:32Z: https://ci.nodejs.org/job/node-test-pull-request/47751/
- Querying data for job/node-test-pull-request/47751/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3412750367
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Nov 7, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45339
✔  Done loading data for nodejs/node/pull/45339
----------------------------------- PR info ------------------------------------
Title      test: skip test-fs-largefile if not enough disk space (#45339)
Author     Rich Trott  (@Trott)
Branch     Trott:fix-fs -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: skip test-fs-largefile if not enough disk space
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 06 Nov 2022 15:55:11 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169721564
   ✔  - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169894956
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-07T17:54:35Z: https://ci.nodejs.org/job/node-test-pull-request/47751/
- Querying data for job/node-test-pull-request/47751/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3412750367
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
test: skip test-fs-largefile if not enough disk space
e080331 
Fixes: nodejs/build#3071

PR-URL: nodejs#45339
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
@Trott
Trott force-pushed the fix-fs branch from bc2bd73 to e080331 Compare November 7, 2022 19:12
@Trott
Trott merged commit e080331 into nodejs:main Nov 7, 2022
@Trott

Trott commented Nov 7, 2022

Copy link
Copy Markdown
Member Author

Landed in e080331
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the fix-fs branch November 7, 2022 19:13
@github-actions github-actions Bot mentioned this pull request Nov 8, 2022
CI Reliability 2022-11-08 nodejs/reliability#422
Open
17 tasks
@github-actions github-actions Bot mentioned this pull request Nov 9, 2022
CI Reliability 2022-11-09 nodejs/reliability#423
Open
14 tasks
@github-actions github-actions Bot mentioned this pull request Nov 10, 2022
CI Reliability 2022-11-10 nodejs/reliability#424
Open
20 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@Trott @RafaelGSS
test: skip test-fs-largefile if not enough disk space
717db1d 
Fixes: nodejs/build#3071

PR-URL: #45339
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
v19.1.0 proposal #45269
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
test: skip test-fs-largefile if not enough disk space
50358f1 
Fixes: nodejs/build#3071

PR-URL: #45339
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
test: skip test-fs-largefile if not enough disk space
7e0332a 
Fixes: nodejs/build#3071

PR-URL: #45339
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
+1 more reviewer
@Linkgoron Linkgoron Linkgoron approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No space left on device OSX 1015

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Trott @nodejs-github-bot @Linkgoron @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.