GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: increase macOS cores to 3 on GitHub CI by Trott · Pull Request #45340 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 6, 2022

Copy link
Copy Markdown
Member

In efbec85, we reduced the cores to 2 based on GitHub documentation. The documentation now says that there are 3 cores.

Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
tools: increase macOS cores to 3 on GitHub CI
271d9e0 
In efbec85, we reduced the cores to 2
based on GitHub documentation. The documentation now says that there are
3 cores.

Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 6, 2022
anonrig
anonrig approved these changes Nov 6, 2022
View reviewed changes
targos
targos approved these changes Nov 6, 2022
View reviewed changes
anonrig
anonrig reviewed Nov 6, 2022
View reviewed changes
Comment thread .github/workflows/test-macos.yml
run: make build-ci -j3 V=1 CONFIG_FLAGS="--error-on-warn"
- name: Test
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
run: make run-ci -j3 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"

@anonrig anonrig Nov 6, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott Can we get the core count using bash, and remove the need to update this workflow in the future? Something like getconf _NPROCESSORS_ONLN

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Trott Trott Nov 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're sure it returns the right number on virtual machines (instead of returning the number available to the physical host that the VM is running on), yeah, that would be great. I'm going to let this run as-is so we can confirm that -j3 is faster than -j2. I'll leave a comment about that on main.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented Nov 6, 2022

Copy link
Copy Markdown
Member Author

The last successful GitHub Action (at the time of this writing) for building/testing on macOS took 1h 50m 36s for the build step, 33m 0s for the test step, and 2h 24m 49s overall. https://github.com/nodejs/node/actions/runs/3404078997/jobs/5661053610

Hopefully this will improve at least a tiny bit on those times... https://github.com/nodejs/node/actions/runs/3405116815/jobs/5662849595
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Nov 6, 2022
View reviewed changes
@Trott

Trott commented Nov 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

The last successful GitHub Action (at the time of this writing) for building/testing on macOS took 1h 50m 36s for the build step, 33m 0s for the test step, and 2h 24m 49s overall. https://github.com/nodejs/node/actions/runs/3404078997/jobs/5661053610

Hopefully this will improve at least a tiny bit on those times... https://github.com/nodejs/node/actions/runs/3405116815/jobs/5662849595

This cuts the build time by about 28%, around a half hour. Let's land it!

Build time went from 1h 50m 36s to 1h 19m 11s. 🚀

Test time went from 33m to 30m. Tests are parallelized by tools/test.py and not the make step, so that checks out.

Total time went form 2h 24m 49s to 1h 50m 33s. 🚀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added build Issues and PRs related to Node.js builds or CI infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed meta Issues and PRs related to the general management of the project. labels Nov 6, 2022
@github-actions

github-actions Bot commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
anonrig and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig mentioned this pull request Nov 6, 2022
Request for large-runners on Github CI #45345
Closed
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 6, 2022
@nodejs-github-bot
nodejs-github-bot merged commit f9fab41 into nodejs:main Nov 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2022

Copy link
Copy Markdown
Collaborator

Landed in f9fab41
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the macos-cores branch November 7, 2022 00:09
Trott added a commit to Trott/io.js that referenced this pull request Nov 7, 2022
@Trott
tools: dynamically determine parallelism on GitHub Actions macOS
58b2bbb 
Refs: nodejs#45340 (comment)
@Trott Trott mentioned this pull request Nov 7, 2022
tools: dynamically determine parallelism on GitHub Actions macOS #45350
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@Trott @RafaelGSS
tools: increase macOS cores to 3 on GitHub CI
97fe8ba 
In efbec85, we reduced the cores to 2
based on GitHub documentation. The documentation now says that there are
3 cores.

Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
PR-URL: #45340
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
v19.1.0 proposal #45269
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 10, 2022
@Trott
tools: dynamically determine parallelism on GitHub Actions macOS
e9a9e1e 
Refs: #45340 (comment)
PR-URL: #45350
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@Trott @ruyadorno
tools: dynamically determine parallelism on GitHub Actions macOS
7c6281a 
Refs: #45340 (comment)
PR-URL: #45350
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
tools: increase macOS cores to 3 on GitHub CI
84b3b96 
In efbec85, we reduced the cores to 2
based on GitHub documentation. The documentation now says that there are
3 cores.

Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
PR-URL: #45340
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
tools: dynamically determine parallelism on GitHub Actions macOS
0f86ff8 
Refs: #45340 (comment)
PR-URL: #45350
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
tools: increase macOS cores to 3 on GitHub CI
e0a8eff 
In efbec85, we reduced the cores to 2
based on GitHub documentation. The documentation now says that there are
3 cores.

Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
PR-URL: #45340
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
tools: dynamically determine parallelism on GitHub Actions macOS
6fafec3 
Refs: #45340 (comment)
PR-URL: #45350
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @nodejs-github-bot @anonrig @targos @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.