GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add automation for updating `libuv` dependency by facutuesca · Pull Request #45362 · nodejs/node

Conversation

@facutuesca

@facutuesca facutuesca commented Nov 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Description

Add a Github Action that checks for new versions of the libuv C library, and creates a PR to update it if a newer version than the one present in the repo is found.

Refs: nodejs/security-wg#828

Details

Currently, if one runs the script to update to version 1.44.2, the uv folder will end up with changes (even though Node's libuv version is also at 1.44.2):

bash tools/dep_updaters/update-libuv.sh 1.44.2
# (...script output....)

git status
# Changes not staged for commit:
#  (use "git add <file>..." to update what will be committed)
#  (use "git restore <file>..." to discard changes in working directory)
#        modified:   deps/uv/include/uv/win.h
#        modified:   deps/uv/src/win/poll.c

This is due to a change made when merging #42340. More specifically, see #42340 (comment). This accounts for the differences between Node's repo and upstream.

Since this seems to be a change that will be reverted in the next release (as per the comment), it should already be taken care of when the update-libuv.sh script is run for that next version.

cc: @lpinca

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 7, 2022
@lpinca

lpinca commented Nov 7, 2022

Copy link
Copy Markdown
Member

Sometimes manual changes to common.gypi and uv.gyp are needed but I guess we will notice this due to compilation failures. Another thing is how to add the changelog in the commit message.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@facutuesca

facutuesca commented Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

Sometimes manual changes to common.gypi and uv.gyp are needed but I guess we will notice this due to compilation failures. Another thing is how to add the changelog in the commit message.

The idea for this script is to automate the copying of the source code to Node's repo, eliminating human errors in that step. Any extra changes (such as fixing the build files, or customizing the commit message) can be done on top of the branch created by the script, by the people reviewing/merging the PR.

My point is: automating the commit message to include the new version's changelog would add complexity, so maybe it could be a future improvement instead of adding it here.
lpinca reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Nov 7, 2022
View reviewed changes
Comment thread tools/update-libuv.sh Outdated

@lpinca lpinca Nov 7, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dist.libuv.org/dist/v$LIBUV_VERSION/libuv-v$LIBUV_VERSION.tar.gz can also be used. I have no preference.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
anonrig
anonrig approved these changes Nov 10, 2022
View reviewed changes

@anonrig anonrig left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 10, 2022
@anonrig

anonrig commented Nov 10, 2022

Copy link
Copy Markdown
Member

@facutuesca Can you resolve the conflicts?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47837/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@facutuesca

facutuesca commented Nov 10, 2022

Copy link
Copy Markdown
Contributor Author

@facutuesca Can you resolve the conflicts?

Fixed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 10, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47849/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 11, 2022
CI Reliability 2022-11-11 nodejs/reliability#425
Open
CI Reliability 2022-11-12 nodejs/reliability#426
Open
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
This was referenced Nov 13, 2022
CI Reliability 2022-11-13 nodejs/reliability#427
Open
CI Reliability 2022-11-14 nodejs/reliability#428
Open
CI Reliability 2022-11-15 nodejs/reliability#429
Open
mhdawson
mhdawson reviewed Nov 15, 2022
View reviewed changes
Comment thread tools/update-libuv.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen gengjiawen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 17, 2022
aduh95
aduh95 reviewed Nov 20, 2022
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Node/Node.js/

node/doc/README.md

Lines 87 to 89 in 184af1c

* Use _Node.js_ and not _Node_, _NodeJS_, or similar variants.
<!-- lint enable prohibited-strings remark-lint-->
* When referring to the executable, _`node`_ is acceptable.

Can you please wrap the lines in the markdown document to 80 chars?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
facutuesca reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread tools/dep_updaters/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/dep_updaters/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/dep_updaters/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/dep_updaters/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/dep_updaters/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/dep_updaters/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/dep_updaters/update-libuv.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/dep_updaters/update-libuv.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/dep_updaters/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 20, 2022
facutuesca added 2 commits November 21, 2022 10:11
@facutuesca
tools: add automation for updating libuv dependency
a392194 
Add a Github Action that checks for new versions of the `libuv` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.

Refs: nodejs/security-wg#828
@facutuesca
tools: move libuv update script to dep_updaters folder
6299a6a
@facutuesca
facutuesca requested a review from aduh95 November 21, 2022 09:14
aduh95
aduh95 reviewed Nov 21, 2022
View reviewed changes
Comment thread tools/dep_updaters/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/dep_updaters/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@facutuesca
tools: add README to dep_updaters folder
2de872c
@facutuesca
facutuesca requested a review from aduh95 November 21, 2022 11:17
aduh95
aduh95 approved these changes Nov 21, 2022
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Nov 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 21, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 59bb198 into nodejs:main Nov 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2022

Copy link
Copy Markdown
Collaborator

Landed in 59bb198
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@facutuesca @ruyadorno
tools: add automation for updating libuv dependency
f3f1aed 
Add a Github Action that checks for new versions of the `libuv` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.

Refs: nodejs/security-wg#828
PR-URL: #45362
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@facutuesca
facutuesca deleted the libuv-ci-update branch December 5, 2022 09:48
@facutuesca facutuesca mentioned this pull request Dec 8, 2022
Automate updates of all dependencies nodejs/security-wg#828
Closed
23 tasks done
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@facutuesca @danielleadams
tools: add automation for updating libuv dependency
9e601db 
Add a Github Action that checks for new versions of the `libuv` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.

Refs: nodejs/security-wg#828
PR-URL: #45362
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@facutuesca @danielleadams
tools: add automation for updating libuv dependency
682a730 
Add a Github Action that checks for new versions of the `libuv` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.

Refs: nodejs/security-wg#828
PR-URL: #45362
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@facutuesca @danielleadams
tools: add automation for updating libuv dependency
66f85fd 
Add a Github Action that checks for new versions of the `libuv` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.

Refs: nodejs/security-wg#828
PR-URL: #45362
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@facutuesca @nodejs-github-bot @lpinca @anonrig @mhdawson @aduh95 @gengjiawen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.