GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: Fix email for Ashley by mhdawson · Pull Request #45364 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Nov 7, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Michael Dawson [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 7, 2022
@mhdawson

mhdawson commented Nov 7, 2022

Copy link
Copy Markdown
Member Author

@AshCripps FYI
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tniessen
tniessen approved these changes Nov 7, 2022
View reviewed changes
@mhdawson
mhdawson force-pushed the ash-email branch from 2c010b1 to 520bf57 Compare November 7, 2022 16:35
AshCripps
AshCripps approved these changes Nov 7, 2022
View reviewed changes

@AshCripps AshCripps left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks for this I didn't realise I had left this in.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented Nov 8, 2022

Copy link
Copy Markdown
Member

We'll want to add a .mailmap entry and update AUTHORS as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson and others added 2 commits November 7, 2022 18:47
@mhdawson @Trott
doc: fix email for Ashley
f28e8f5 
Signed-off-by: Michael Dawson <[email protected]>
@Trott
fixup! doc: fix email for Ashley
1bd5c04
@Trott
Trott force-pushed the ash-email branch from 520bf57 to 1bd5c04 Compare November 8, 2022 02:50
@Trott

Trott commented Nov 8, 2022

Copy link
Copy Markdown
Member

We'll want to add a .mailmap entry and update AUTHORS as well.

I did this and pushed the results in a fixup commit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Nov 8, 2022
@github-actions

github-actions Bot commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
AshCripps and BethGriggs reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Nov 8, 2022
View reviewed changes
@IFirstYou

This comment was marked as spam.

Sign in to view
@Trott

This comment was marked as resolved.

Sign in to view
BethGriggs
BethGriggs approved these changes Nov 8, 2022
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 8, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 8, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 59938e3 into nodejs:main Nov 8, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2022

Copy link
Copy Markdown
Collaborator

Landed in 59938e3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@mhdawson @RafaelGSS
doc: fix email for Ashley
ba45373 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #45364
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
v19.1.0 proposal #45269
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@mhdawson @danielleadams
doc: fix email for Ashley
bef5d3d 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #45364
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@mhdawson @danielleadams
doc: fix email for Ashley
846b1ae 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #45364
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@tniessen tniessen tniessen approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
+1 more reviewer
@AshCripps AshCripps AshCripps approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@mhdawson @Trott @IFirstYou @nodejs-github-bot @tniessen @BethGriggs @AshCripps
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.