GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add arm64 to os.machine() by sno2 · Pull Request #45374 · nodejs/node

Conversation

@sno2

@sno2 sno2 commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

arm64 is a much more common machine name than s390x so I think it deserves a spot on in the sunlight.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. os Issues and PRs related to the os subsystem. labels Nov 8, 2022
anonrig
anonrig approved these changes Nov 8, 2022
View reviewed changes
Trott
Trott approved these changes Nov 8, 2022
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you amend the commit message to be doc: add arm64 to os.machine() and force push to this branch?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sno2 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@sno2 sno2 changed the title chore(os): add arm64 to os.machine() doc: add arm64 to os.machine() Nov 8, 2022
cjihrig
cjihrig approved these changes Nov 8, 2022
View reviewed changes
@sno2
doc: add arm64 to os.machine()
b11e051
lpinca
lpinca approved these changes Nov 8, 2022
View reviewed changes
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
jasnell
jasnell approved these changes Nov 16, 2022
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 17, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 17, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 490c3d6 into nodejs:main Nov 17, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

Landed in 490c3d6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sno2
sno2 deleted the patch-1 branch November 17, 2022 22:00
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@sno2 @ruyadorno
doc: add arm64 to os.machine()
4de67d1 
PR-URL: #45374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@sno2 @danielleadams
doc: add arm64 to os.machine()
7628ffb 
PR-URL: #45374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@sno2 @danielleadams
doc: add arm64 to os.machine()
8b44c61 
PR-URL: #45374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. os Issues and PRs related to the os subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@sno2 @nodejs-github-bot @jasnell @Trott @lpinca @anonrig @cjihrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.