GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — async_hooks: add hook to stop propagation by Flarna · Pull Request #45386 · nodejs/node

Conversation

@Flarna

@Flarna Flarna commented Nov 9, 2022

Copy link
Copy Markdown
Member

Add hook to AsyncLocalStorage to allow user to stop propagation. This is needed to avoid leaking a store if e.g. the store indicates that its operations are finished or it reached its time to live.

fyi @nodejs/diagnostics

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tony-go and bricss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@Flarna
async_hooks: add hook to stop propagation
133d061 
Add hook to AsyncLocalStorage to allow user to stop propagation.
This is needed to avoid leaking a store if e.g. the store indicates
that its operations are finished or it reached its time to live.
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. labels Nov 9, 2022
@Flarna
fixup: correct link
046b501
Flarna
Flarna commented Nov 9, 2022
View reviewed changes
Comment thread lib/async_hooks.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Flarna Flarna added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 9, 2022
@Flarna
fixup: lint
b9bd35d
@Flarna Flarna added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Nov 9, 2022
Qard
Qard requested changes Nov 9, 2022
View reviewed changes
Comment thread lib/async_hooks.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/async_context.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Flarna added 2 commits November 10, 2022 10:12
@Flarna
rename onPropagateCb to onPropagate
1c14ccf
@Flarna
don't set undefined on new resource
f49048a
tony-go
tony-go reviewed Nov 10, 2022
View reviewed changes
Comment thread lib/async_hooks.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Flarna added 2 commits November 10, 2022 13:56
@Flarna
test wrong usage
13b1745
@Flarna
fixup: lint
3c77eaf
Qard
Qard approved these changes Nov 10, 2022
View reviewed changes
tony-go
tony-go approved these changes Nov 11, 2022
View reviewed changes

@tony-go tony-go left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
JungMinu
JungMinu approved these changes Nov 12, 2022
View reviewed changes
legendecas
legendecas reviewed Nov 14, 2022
View reviewed changes
Comment thread lib/async_hooks.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Flarna @legendecas
use kEmptyObject instead {}
358297c 
Co-authored-by: Chengzhong Wu <[email protected]>
@Flarna Flarna added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 14, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47932/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
legendecas
legendecas approved these changes Nov 15, 2022
View reviewed changes
@Flarna Flarna added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 15, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 67d1831 into nodejs:main Nov 15, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

Landed in 67d1831
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Flarna
Flarna deleted the als-propagate branch November 15, 2022 12:29
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@Flarna @ruyadorno
async_hooks: add hook to stop propagation
7cff1e1 
Add hook to AsyncLocalStorage to allow user to stop propagation.
This is needed to avoid leaking a store if e.g. the store indicates
that its operations are finished or it reached its time to live.

PR-URL: #45386
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Flarna @danielleadams
async_hooks: add hook to stop propagation
2d3c6da 
Add hook to AsyncLocalStorage to allow user to stop propagation.
This is needed to avoid leaking a store if e.g. the store indicates
that its operations are finished or it reached its time to live.

PR-URL: #45386
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Flarna @danielleadams
async_hooks: add hook to stop propagation
40123a6 
Add hook to AsyncLocalStorage to allow user to stop propagation.
This is needed to avoid leaking a store if e.g. the store indicates
that its operations are finished or it reached its time to live.

PR-URL: #45386
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@legendecas legendecas mentioned this pull request Jan 26, 2023
AsyncLocalStorage without Async Hooks #46265
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes
@JungMinu JungMinu JungMinu approved these changes
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@tony-go tony-go tony-go approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Flarna @nodejs-github-bot @Qard @JungMinu @legendecas @tony-go
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.