GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: simplify .eslintrc.js by Trott · Pull Request #45397 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 10, 2022

Copy link
Copy Markdown
Member

Remove explicit setting of configuration options in rules when those options are the defaults.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 10, 2022
@Trott
tools: simplify .eslintrc.js
b3afaca 
Remove explicit setting of configuration options in rules when those
options are the defaults.
@Trott
Trott force-pushed the defaults branch from a1df915 to b3afaca Compare November 10, 2022 03:59
@mscdex

mscdex commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

Do we have any easy way of telling if the defaults change in the future?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Do we have any easy way of telling if the defaults change in the future?

Probably not. I suppose that could be a case for never using the defaults implicitly and spelling everything out in the config file, but I would prefer to go in the opposite direction of configuration file simplicity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joyeecheung
joyeecheung approved these changes Nov 10, 2022
View reviewed changes
lpinca
lpinca approved these changes Nov 10, 2022
View reviewed changes
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 12, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 12, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 9baf748 into nodejs:main Nov 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2022

Copy link
Copy Markdown
Collaborator

Landed in 9baf748
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@Trott @ruyadorno
tools: simplify .eslintrc.js
93bc2ba 
Remove explicit setting of configuration options in rules when those
options are the defaults.

PR-URL: #45397
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
tools: simplify .eslintrc.js
275301e 
Remove explicit setting of configuration options in rules when those
options are the defaults.

PR-URL: #45397
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
tools: simplify .eslintrc.js
0f45c90 
Remove explicit setting of configuration options in rules when those
options are the defaults.

PR-URL: #45397
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @mscdex @nodejs-github-bot @lpinca @joyeecheung
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.