GeezerVison

Review requested:

• @nodejs/actions

CC @targos

This would force us to land fast-track PRs proposed for a shorter-than-standard waiting period before landing. PRs manually, I'm not sure it's desirable.

not sure how we can test this

You can use https://github.com/nodejs/node-auto-test for this kind of things.

This would force us to land fast-track PRs that do not need to wait for 48 hours to land. PRs manually, I'm not sure it's desirable.

I guess we can merge the result of two queries

@aduh95 added support for fast-track PRs proposed for a shorter-than-standard waiting period before landing.

@panva @aduh95 tested:
current result of https://github.com/nodejs/node-auto-test/issues?q=is%3Aopen+label%3Acommit-queue+sort%3Aupdated-desc is:

the commit queue resulted in attempting to commit PRs 31 (commit-queue & < 2 days) and 50 (commit-queue & fast track):
https://github.com/nodejs/node-auto-test/actions/runs/3439433893/jobs/5736726139

amazing @panva :) too bad I cannot use this on this PR yet :/

If we could query for number of approvals we could also add minimum 2 to the 2 day query and add a third query for minimum 1 and 7 days ;)

If we could query for number of approvals we could also add minimum 2 to the 2 day query and add a third query for minimum 1 and 7 days ;)

ncu already does that

If we could query for number of approvals we could also add minimum 2 to the 2 day query and add a third query for minimum 1 and 7 days ;)

ncu already does that

by then the label is removed and ncu will fail the commit queue.

Yeah 😐

But it's mostly crypto and cpp PRs that don't manage to get at least two approvals in 2 days.

This is still a great feature. Add CQ label as soon as you have two or enough fast track thumbs. Then stop worrying about the PR.

Note: the commit message should start with a verb after the subsystem (and the subsystem should probably be tools: instead of meta:), e.g. tools: do not run CQ on non-fast-tracked PRs open for less than 2 days.

Landed in 119559a