GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v19.x] lib: fix eslint early return by RafaelGSS · Pull Request #45409 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Nov 10, 2022

Copy link
Copy Markdown
Member

The #45243 updated eslint, and apparently when you specify a @returns early returns aren't considered valid. This PR fixes this lint issue.

In the main branch it's not failing because #41276 fixes it indirectly.

FYI @Trott

cc: @nodejs/releasers this probably needs to be backported/cherry-picked to all active release lines.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@RafaelGSS
lib: fix eslint early return
8e21b8f 
The nodejs#45243 upgraded eslint
and apparently, when you specific a `@returns` early returns
aren't considered valid. This PR fixes this lint issue.
@nodejs-github-bot nodejs-github-bot added events Issues and PRs related to EventEmitter and the events module. needs-ci PRs that need a full CI run. v19.x labels Nov 10, 2022
@RafaelGSS

RafaelGSS commented Nov 10, 2022

Copy link
Copy Markdown
Member Author

I'm requesting fast-track because I need to include it on #45269.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 10, 2022
@github-actions

github-actions Bot commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.
panva, lpinca, BethGriggs, and bricss reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS

RafaelGSS commented Nov 10, 2022

Copy link
Copy Markdown
Member Author

Do I need CI for this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
panva
panva approved these changes Nov 10, 2022
View reviewed changes
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 10, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 10, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
lpinca
lpinca approved these changes Nov 10, 2022
View reviewed changes
ruyadorno
ruyadorno approved these changes Nov 10, 2022
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Nov 11, 2022
CI Reliability 2022-11-11 nodejs/reliability#425
Open
19 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@BethGriggs BethGriggs added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47864/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BethGriggs
BethGriggs approved these changes Nov 11, 2022
View reviewed changes
@RafaelGSS

RafaelGSS commented Nov 11, 2022

Copy link
Copy Markdown
Member Author

The Windows issue is a known problem at the moment, and considering the fact we need this patch for #45269 and a new CI will run for the proposal, I'll land it anyway.
BethGriggs reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS added a commit that referenced this pull request Nov 11, 2022
@RafaelGSS
lib: fix eslint early return
e2181e0 
The #45243 upgraded eslint
and apparently, when you specific a `@returns` early returns
aren't considered valid. This PR fixes this lint issue.

PR-URL: #45409
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@RafaelGSS

RafaelGSS commented Nov 11, 2022

Copy link
Copy Markdown
Member Author

Landed in e2181e0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS closed this Nov 11, 2022
@RafaelGSS

RafaelGSS commented Nov 11, 2022

Copy link
Copy Markdown
Member Author

Ref: nodejs/build#3075
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Nov 11, 2022
v19.1.0 proposal #45269
Merged
This was referenced Nov 12, 2022
CI Reliability 2022-11-12 nodejs/reliability#426
Open
CI Reliability 2022-11-13 nodejs/reliability#427
Open
This was referenced Nov 14, 2022
CI Reliability 2022-11-14 nodejs/reliability#428
Open
CI Reliability 2022-11-15 nodejs/reliability#429
Open
CI Reliability 2022-11-16 nodejs/reliability#430
Open
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@RafaelGSS @danielleadams
lib: fix eslint early return
93eb5bd 
The #45243 upgraded eslint
and apparently, when you specific a `@returns` early returns
aren't considered valid. This PR fixes this lint issue.

PR-URL: #45409
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@RafaelGSS @danielleadams
lib: fix eslint early return
b9d4ac2 
The #45243 upgraded eslint
and apparently, when you specific a `@returns` early returns
aren't considered valid. This PR fixes this lint issue.

PR-URL: #45409
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes
@panva panva panva approved these changes
@lpinca lpinca lpinca approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

events Issues and PRs related to EventEmitter and the events module. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@RafaelGSS @nodejs-github-bot @ruyadorno @panva @lpinca @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.