GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — diagnostics_channel: built-in channels should remain experimental by Qard · Pull Request #45423 · nodejs/node

Conversation

@Qard

@Qard Qard commented Nov 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

An unintended side effect of stabilizing diagnostics_channel was that it was unclear that the built-in channels were not part of that stabilization. The built-in channels should be stabilized independently.

Fixes #45400

cc @nodejs/diagnostics

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Qard Qard added the diagnostics_channel Issues and PRs related to the diagnostics_channel module. label Nov 11, 2022
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 11, 2022
theanarkh
theanarkh approved these changes Nov 11, 2022
View reviewed changes
tony-go
tony-go approved these changes Nov 11, 2022
View reviewed changes
Flarna
Flarna approved these changes Nov 11, 2022
View reviewed changes
Flarna
Flarna reviewed Nov 11, 2022
View reviewed changes
Comment thread doc/api/diagnostics_channel.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
@Qard
Qard force-pushed the built-in-diagnostics-channels-are-not-stable branch from 711bbfa to 361b728 Compare November 14, 2022 18:42
RafaelGSS
RafaelGSS approved these changes Nov 14, 2022
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Qard
Qard force-pushed the built-in-diagnostics-channels-are-not-stable branch from 361b728 to d6a71bc Compare November 14, 2022 21:40
@Qard

Qard commented Nov 15, 2022

Copy link
Copy Markdown
Member Author

I'm unclear why the markdown lint continues to fail. I see a bunch of warnings but no error messages yet it seems to fail for some reason. 🤔
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
legendecas
legendecas reviewed Nov 15, 2022
View reviewed changes
Comment thread src/node_contextify.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Stephen Belanger
diagnostics_channel: built-in channels should remain experimental
b407a4f
@Qard
Qard force-pushed the built-in-diagnostics-channels-are-not-stable branch from d6a71bc to b407a4f Compare November 15, 2022 16:38
Flarna
Flarna approved these changes Nov 15, 2022
View reviewed changes
@Flarna Flarna added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 15, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 2f3da6c into nodejs:main Nov 15, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

Landed in 2f3da6c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Qard
Qard deleted the built-in-diagnostics-channels-are-not-stable branch November 15, 2022 20:08
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
Stephen Belanger @ruyadorno
diagnostics_channel: built-in channels should remain experimental
9e0e97c 
PR-URL: #45423
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Stephen Belanger @danielleadams
diagnostics_channel: built-in channels should remain experimental
4379368 
PR-URL: #45423
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Stephen Belanger @danielleadams
diagnostics_channel: built-in channels should remain experimental
40a29aa 
PR-URL: #45423
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas left review comments
@Flarna Flarna Flarna approved these changes
@theanarkh theanarkh theanarkh approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
+1 more reviewer
@tony-go tony-go tony-go approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. diagnostics_channel Issues and PRs related to the diagnostics_channel module. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stability of built in diagnostics channels

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Qard @nodejs-github-bot @legendecas @Flarna @theanarkh @tony-go @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.