GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: condense experimental warning message by Trott · Pull Request #45424 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Before:

$ node --watch fhqwhgads
(node:26196) ExperimentalWarning: Watch mode is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

After:

$ ./node --watch fhqwhgads
(node:78033) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2022
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 11, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47854/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 11, 2022

Copy link
Copy Markdown
Member Author

Hmmm...that didn't work...guess the punctuation gets pulled out later on.....
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott marked this pull request as draft November 11, 2022 04:38
@Trott
Trott force-pushed the period branch from bb91037 to d77a0ca Compare November 11, 2022 04:47
@Trott

Trott commented Nov 11, 2022

Copy link
Copy Markdown
Member Author

Ideally, I think, this would be just one sentence (which it is now) and might omit the period if it is being followed by a stack trace but include a period if it isn't.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott force-pushed the period branch from d77a0ca to ffdd632 Compare November 11, 2022 04:48
@Trott

Trott commented Nov 11, 2022

Copy link
Copy Markdown
Member Author

Leaving the period off when it's a single sentence isn't as weird and noticeable as when it's multiple sentences so I think I'll leave it like that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott force-pushed the period branch from ffdd632 to 818141e Compare November 11, 2022 05:07
@Trott
Trott marked this pull request as ready for review November 11, 2022 05:07
@Trott

Trott commented Nov 11, 2022

Copy link
Copy Markdown
Member Author

Honestly, I wonder if the message would be better as just " is an experimental feature" and that's it. That would probably get these messages under 80 chars for the most part and probably not reduce their effectiveness. "Might change at any time" is kind of weird anyway. It's not going to change at any time. It's going to change when there's a new release and the user updates. I'd think "experimental" is plenty scary enough and we don't need to explicitly warn people that the feature might change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott changed the title src: add missing punctuation to warning src: condense experimental warning message Nov 11, 2022
@Trott
Trott force-pushed the period branch from 818141e to d62c227 Compare November 11, 2022 05:16
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47855/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

There are test failures to address.

"Might change at any time" is kind of weird anyway. It's not going to change at any time. It's going to change when there's a new release and the user updates.

I guess it's there to communicate that semver rules don't apply for experimental features.
Trott reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 12, 2022
CI Reliability 2022-11-12 nodejs/reliability#426
Open
19 tasks
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
@Trott
src: condense experimental warning message
dc3708d
@Trott
Trott force-pushed the period branch from d62c227 to dc3708d Compare November 12, 2022 03:19
anonrig
anonrig approved these changes Nov 12, 2022
View reviewed changes
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 12, 2022
MoLow
MoLow approved these changes Nov 12, 2022
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47893/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 13, 2022
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 13, 2022
@github-actions github-actions Bot mentioned this pull request Nov 13, 2022
CI Reliability 2022-11-13 nodejs/reliability#427
Open
25 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 13, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 1255db7 into nodejs:main Nov 13, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2022

Copy link
Copy Markdown
Collaborator

Landed in 1255db7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the period branch November 13, 2022 04:39
This was referenced Nov 14, 2022
CI Reliability 2022-11-14 nodejs/reliability#428
Open
CI Reliability 2022-11-15 nodejs/reliability#429
Open
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@Trott @ruyadorno
src: condense experimental warning message
a483d12 
PR-URL: #45424
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
src: condense experimental warning message
076389b 
PR-URL: #45424
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
src: condense experimental warning message
5544ce4 
PR-URL: #45424
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @nodejs-github-bot @aduh95 @anonrig @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.