GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove flaky designation for test-worker-http2-stream-terminate by Trott · Pull Request #45438 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 12, 2022

Copy link
Copy Markdown
Member

Closes: #43084

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 12, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 12, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 12, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47895/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 12, 2022

Copy link
Copy Markdown
Member Author

Stress test suggests this isn't flaky anymore, so I'm going to move this out of draft mode.

https://ci.nodejs.org/job/node-stress-single-test/378/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott marked this pull request as ready for review November 12, 2022 21:10
RafaelGSS
RafaelGSS approved these changes Nov 12, 2022
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot mentioned this pull request Nov 13, 2022
CI Reliability 2022-11-13 nodejs/reliability#427
Open
25 tasks
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 13, 2022
@Trott
test: remove flaky designation for test-worker-http2-stream-terminate
2e1171b 
Closes: nodejs#43084
@Trott
Trott force-pushed the de-flaky branch from 3c960ac to 2e1171b Compare November 13, 2022 04:42
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 13, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 13, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47908/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Nov 13, 2022
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 13, 2022
@github-actions github-actions Bot mentioned this pull request Nov 14, 2022
CI Reliability 2022-11-14 nodejs/reliability#428
Open
25 tasks
@ywave620

ywave620 commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

Should we move this test back to parallel? I checked the CI history, after this test is moved to sequential, it has reliably paased in the last few months.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 14, 2022
@nodejs-github-bot
nodejs-github-bot merged commit badc631 into nodejs:main Nov 14, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator

Landed in badc631
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the de-flaky branch November 14, 2022 22:52
This was referenced Nov 15, 2022
CI Reliability 2022-11-15 nodejs/reliability#429
Open
CI Reliability 2022-11-16 nodejs/reliability#430
Open
CI Reliability 2022-11-17 nodejs/reliability#431
Open
CI Reliability 2022-11-18 nodejs/reliability#432
Open
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@Trott @ruyadorno
test: remove flaky designation for test-worker-http2-stream-terminate
00a3b5f 
Closes: #43084
PR-URL: #45438
Fixes: #43084
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
test: remove flaky designation for test-worker-http2-stream-terminate
314f10e 
Closes: #43084
PR-URL: #45438
Fixes: #43084
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
test: remove flaky designation for test-worker-http2-stream-terminate
85c634d 
Closes: #43084
PR-URL: #45438
Fixes: #43084
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test/parallel/test-worker-http2-stream-terminate.js

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @nodejs-github-bot @ywave620 @lpinca @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.