GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — benchmark: add text-encoder benchmark by anonrig · Pull Request #45450 · nodejs/node

Conversation

anonrig commented Nov 13, 2022

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and Qard reacted with thumbs up emoji

Qard reacted with heart emoji

All reactions

👍 2 reactions
❤️ 1 reaction

nodejs-github-bot added benchmark

Issues and PRs related to Node.js benchmarks and benchmarking infrastructure.

util Issues and PRs related to the built-in util module. labels

Nov 13, 2022

mscdex reviewed

Nov 13, 2022

View reviewed changes

Comment thread

benchmark/util/text-encoder.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

anonrig force-pushed the benchmark/text-encoder branch from fbe8351 to 8f787c6 Compare

November 13, 2022 19:52

anonrig added performance

Issues and PRs related to the performance of Node.js.

request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Nov 13, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 13, 2022

nodejs-github-bot commented Nov 13, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47914/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Nov 14, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47916/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 commented Nov 14, 2022

Copy link

Copy Markdown

Contributor

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1220/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Nov 14, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47927/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Qard approved these changes

Nov 14, 2022

View reviewed changes

Qard left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small suggestion

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

benchmark/util/text-encoder.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

anonrig force-pushed the benchmark/text-encoder branch from 8f787c6 to 4f9fce7 Compare

November 15, 2022 14:26

anonrig requested a review from Qard

November 15, 2022 14:27

anonrig added author ready

PRs with CI started, the required approvals, and no outstanding review comments.

request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Nov 15, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 15, 2022

nodejs-github-bot commented Nov 15, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47948/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Qard approved these changes

Nov 15, 2022

View reviewed changes

jasnell reviewed

Nov 16, 2022

View reviewed changes

Comment thread

benchmark/util/text-encoder.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

jasnell approved these changes

Nov 16, 2022

View reviewed changes


          benchmark: add text-encoder benchmark

bb344f1

anonrig force-pushed the benchmark/text-encoder branch from 4f9fce7 to bb344f1 Compare

November 17, 2022 13:59

anonrig requested review from Qard and jasnell

November 17, 2022 13:59

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 17, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 17, 2022

nodejs-github-bot commented Nov 17, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47987/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Qard approved these changes

Nov 17, 2022

View reviewed changes

lpinca approved these changes

Nov 18, 2022

View reviewed changes

lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 18, 2022

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 18, 2022

nodejs-github-bot merged commit cb96a13 into main

Nov 18, 2022

nodejs-github-bot commented Nov 18, 2022

Copy link

Copy Markdown

Collaborator

Landed in cb96a13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot deleted the benchmark/text-encoder branch

November 18, 2022 19:48

ruyadorno pushed a commit that referenced this pull request

Nov 21, 2022


          benchmark: add text-encoder benchmark

26ad54c

PR-URL: #45450
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

ruyadorno mentioned this pull request

Nov 24, 2022

v19.2.0 proposal #45615

Merged

danielleadams mentioned this pull request

Dec 30, 2022

v18.13.0 release proposal #46025

Merged

danielleadams pushed a commit that referenced this pull request

Dec 30, 2022


          benchmark: add text-encoder benchmark

b0c42b0

PR-URL: #45450
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

danielleadams pushed a commit that referenced this pull request

Jan 3, 2023


          benchmark: add text-encoder benchmark

fcf6188

PR-URL: #45450
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

danielleadams pushed a commit that referenced this pull request

Jan 5, 2023


          benchmark: add text-encoder benchmark

ec7ef3c

PR-URL: #45450
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Reviewers

Qard

Qard approved these changes

lpinca

lpinca approved these changes

jasnell

Awaiting requested review from jasnell

+1 more reviewer

mscdex

mscdex left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

benchmark

Issues and PRs related to Node.js benchmarks and benchmarking infrastructure.

performance

Issues and PRs related to the performance of Node.js.

util

Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.