GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: update uses of _jabber._tcp.google.com by cjihrig · Pull Request #45451 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Nov 13, 2022

Copy link
Copy Markdown
Contributor

_jabber._tcp.google.com seems to have stopped working, causing a couple failures in the internet test suite. This commit changes the host to _caldav._tcp.google.com. After this change there is still one unrelated failure in the internet suite.

Refs: denoland/std#2881

Upstreamed with permission from @kt3k.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cjihrig
test: update uses of _jabber._tcp.google.com
c303a54 
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 13, 2022
santigimeno
santigimeno approved these changes Nov 13, 2022
View reviewed changes
anonrig
anonrig approved these changes Nov 13, 2022
View reviewed changes
tniessen
tniessen approved these changes Nov 13, 2022
View reviewed changes
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 13, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 13, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47915/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Nov 14, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47925/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Nov 15, 2022
View reviewed changes
@cjihrig cjihrig added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Nov 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 15, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

Landed in 2f3da6c...7675749
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot closed this Nov 15, 2022
nodejs-github-bot pushed a commit that referenced this pull request Nov 15, 2022
@cjihrig @nodejs-github-bot
test: update uses of _jabber._tcp.google.com
7675749 
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
PR-URL: #45451
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@cjihrig
cjihrig deleted the internet branch November 15, 2022 20:31
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@cjihrig @ruyadorno
test: update uses of _jabber._tcp.google.com
45b54ee 
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
PR-URL: #45451
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@cjihrig @danielleadams
test: update uses of _jabber._tcp.google.com
d550795 
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
PR-URL: #45451
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@cjihrig @danielleadams
test: update uses of _jabber._tcp.google.com
cac449f 
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.

Refs: denoland/std#2881
PR-URL: #45451
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@santigimeno santigimeno santigimeno approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@tniessen tniessen tniessen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@cjihrig @nodejs-github-bot @Trott @santigimeno @lpinca @anonrig @tniessen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.