GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Aix: Fix V8 canary build by V-for-Vasili · Pull Request #45496 · nodejs/node

Conversation

@V-for-Vasili

@V-for-Vasili V-for-Vasili commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

Use -fno-extern-tls-init to avoid link error with extern thread_local

Fixes: nodejs/node-v8#234 (comment)

Related (gcc bug):
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100641

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and iamshcc reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Nov 17, 2022
@V-for-Vasili
V-for-Vasili force-pushed the Aix-fno-extern-tls-init-flag branch from ce6d0ff to c766a9e Compare November 17, 2022 16:05
@V-for-Vasili
gyp: fix v8 canary build on aix
37c6beb
@V-for-Vasili
V-for-Vasili force-pushed the Aix-fno-extern-tls-init-flag branch from c766a9e to 37c6beb Compare November 17, 2022 16:09
@V-for-Vasili
V-for-Vasili marked this pull request as ready for review November 17, 2022 16:33
@V-for-Vasili V-for-Vasili mentioned this pull request Nov 17, 2022
Review state of canary in CI nodejs/node-v8#234
Closed
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 17, 2022
anonrig
anonrig approved these changes Nov 17, 2022
View reviewed changes
@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 17, 2022
cjihrig
cjihrig reviewed Nov 17, 2022
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok if the CI passes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cjihrig
cjihrig approved these changes Nov 17, 2022
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 17, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47991/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/4994/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4994/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4994/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Nov 17, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47998/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 18, 2022
CI Reliability 2022-11-18 nodejs/reliability#432
Open
12 tasks
ryzokuken
ryzokuken approved these changes Nov 18, 2022
View reviewed changes
@targos

targos commented Nov 18, 2022

Copy link
Copy Markdown
Member

Test with this on top of V8 lkgr: https://ci.nodejs.org/job/node-test-commit-aix/43755/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48006/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Nov 18, 2022
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 18, 2022
@github-actions github-actions Bot mentioned this pull request Nov 19, 2022
CI Reliability 2022-11-19 nodejs/reliability#433
Open
10 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 19, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 87e6943 into nodejs:main Nov 19, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator

Landed in 87e6943
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 20, 2022
CI Reliability 2022-11-20 nodejs/reliability#434
Open
CI Reliability 2022-11-21 nodejs/reliability#435
Open
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@V-for-Vasili @ruyadorno
gyp: fix v8 canary build on aix
e0a271e 
PR-URL: #45496
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@github-actions github-actions Bot mentioned this pull request Nov 22, 2022
CI Reliability 2022-11-22 nodejs/reliability#436
Open
15 tasks
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@V-for-Vasili @danielleadams
gyp: fix v8 canary build on aix
57276c4 
PR-URL: #45496
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@V-for-Vasili @danielleadams
gyp: fix v8 canary build on aix
9ab00f5 
PR-URL: #45496
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@V-for-Vasili @danielleadams
gyp: fix v8 canary build on aix
1dda8da 
PR-URL: #45496
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
+2 more reviewers
@targos targos targos approved these changes
@ryzokuken ryzokuken ryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review state of canary in CI

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@V-for-Vasili @nodejs-github-bot @targos @anonrig @cjihrig @richardlau @ryzokuken
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.