GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: add missing step in update-base64.sh script by facutuesca · Pull Request #45509 · nodejs/node

Conversation

@facutuesca

@facutuesca facutuesca commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

This PR adds an extra step to the update-base64.sh script, which adds an empty config.h header after updating base64.

The reason for this is that config.h needs to exist in order to compile base64. In upstream, this header is used to define which processor extensions should be supported (see here). Since in Node's build this is handled by the base64.gyp file, we leave the config.h file empty.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@facutuesca
tools: add missing step in update-base64.sh script
c9cf913
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 18, 2022
@facutuesca facutuesca mentioned this pull request Nov 18, 2022
deps: update base64 to 0.5.0 #45440
Closed
@facutuesca

facutuesca commented Nov 18, 2022

Copy link
Copy Markdown
Contributor Author

cc @targos @jasnell
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Nov 18, 2022

Copy link
Copy Markdown
Member

Could you use the script to make the actual update in a second commit? This will validate that it works next time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@facutuesca

facutuesca commented Nov 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Could you use the script to make the actual update in a second commit? This will validate that it works next time.

@targos What do you mean? AFAICT when this is merged, the next time the script runs a new PR will be created with the changes here minus the deletion of config.h, and CI will validate that everything compiles/runs correctly
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Nov 18, 2022

Copy link
Copy Markdown
Member

You're right, but I don't want to wait for the automated PR to validate that everything works correctly. It can be easily done here IMO.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@facutuesca
deps: update base64 to 0.5.0
fe3119c
@facutuesca

facutuesca commented Nov 18, 2022

Copy link
Copy Markdown
Contributor Author

You're right, but I don't want to wait for the automated PR to validate that everything works correctly. It can be easily done here IMO.

@targos Done!
targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Nov 18, 2022
View reviewed changes
lpinca
lpinca approved these changes Nov 18, 2022
View reviewed changes
anonrig
anonrig approved these changes Nov 18, 2022
View reviewed changes
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Nov 18, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 18, 2022
richardlau
richardlau approved these changes Nov 18, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48012/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos mentioned this pull request Nov 20, 2022
deps: update base64 to 0.5.0 #45530
Closed
@targos targos added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Nov 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 20, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 20, 2022

Copy link
Copy Markdown
Collaborator

Landed in 8822f40...4bee69a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot closed this Nov 20, 2022
nodejs-github-bot pushed a commit that referenced this pull request Nov 20, 2022
@facutuesca @nodejs-github-bot
tools: add missing step in update-base64.sh script
c0bbcd4 
PR-URL: #45509
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Nov 20, 2022
@facutuesca @nodejs-github-bot
deps: update base64 to 0.5.0
4bee69a 
PR-URL: #45509
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@facutuesca @ruyadorno
tools: add missing step in update-base64.sh script
d4f30f0 
PR-URL: #45509
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@facutuesca @ruyadorno
deps: update base64 to 0.5.0
43e002e 
PR-URL: #45509
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@facutuesca @danielleadams
tools: add missing step in update-base64.sh script
c97df11 
PR-URL: #45509
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@facutuesca @danielleadams
deps: update base64 to 0.5.0
f200e35 
PR-URL: #45509
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@facutuesca @danielleadams
tools: add missing step in update-base64.sh script
360c7be 
PR-URL: #45509
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@facutuesca @danielleadams
deps: update base64 to 0.5.0
02eabaf 
PR-URL: #45509
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@facutuesca @danielleadams
tools: add missing step in update-base64.sh script
6b08409 
PR-URL: #45509
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@facutuesca @danielleadams
deps: update base64 to 0.5.0
67489ee 
PR-URL: #45509
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@facutuesca @targos @nodejs-github-bot @lpinca @anonrig @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.