GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: revise pull request guide text about code by Trott · Pull Request #45519 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 19, 2022

Copy link
Copy Markdown
Member

Fixes: #45502

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
test: revise pull request guide text about code
27e92a0 
Fixes: nodejs#45502
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 19, 2022
@Trott
fixup! test: revise pull request guide text about code
5374a5c
@Trott Trott mentioned this pull request Nov 19, 2022
unneded "." in pull-requests.md file #45502
Closed
legendecas
legendecas approved these changes Nov 19, 2022
View reviewed changes
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 19, 2022
lpinca
lpinca approved these changes Nov 19, 2022
View reviewed changes
@lpinca lpinca added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 19, 2022
@github-actions

github-actions Bot commented Nov 19, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.
lpinca and anonrig reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tniessen
tniessen approved these changes Nov 19, 2022
View reviewed changes
@anonrig anonrig added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Nov 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 19, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 5af2021 into nodejs:main Nov 19, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator

Landed in 5af2021
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the foo branch November 19, 2022 20:07
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@Trott @ruyadorno
test: revise pull request guide text about code
c9ba0b7 
Fixes: #45502
PR-URL: #45519
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
test: revise pull request guide text about code
8212eab 
Fixes: #45502
PR-URL: #45519
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
test: revise pull request guide text about code
305d4de 
Fixes: #45502
PR-URL: #45519
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@Trott @danielleadams
test: revise pull request guide text about code
151ce0a 
Fixes: #45502
PR-URL: #45519
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@legendecas legendecas legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unneded "." in pull-requests.md file

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @nodejs-github-bot @lpinca @tniessen @legendecas @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.