GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add missing documentation for paramEncoding by tniessen · Pull Request #45523 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Nov 19, 2022

Copy link
Copy Markdown
Member

This option has existed ever since generateKeyPair was added in 2019 or so, but I apparently forgot to document it.

Thanks to @panva for noticing this :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tniessen
doc: add missing documentation for paramEncoding
3fc7871 
This option has existed ever since generateKeyPair was added in 2019 or
so, but I apparently forgot to document it.
@tniessen
tniessen requested a review from panva November 19, 2022 19:49
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation. labels Nov 19, 2022
anonrig
anonrig approved these changes Nov 19, 2022
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 19, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 19, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48025/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
panva
panva approved these changes Nov 19, 2022
View reviewed changes
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 19, 2022
panva
panva reviewed Nov 19, 2022
View reviewed changes
Comment thread doc/api/crypto.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/crypto.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Nov 19, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Nov 20, 2022
CI Reliability 2022-11-20 nodejs/reliability#434
Open
14 tasks
cjihrig
cjihrig approved these changes Nov 20, 2022
View reviewed changes
@tniessen @panva
Apply suggestions from code review
e740167 
Co-authored-by: Filip Skokan <[email protected]>
panva
panva approved these changes Nov 20, 2022
View reviewed changes
@panva panva added commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Nov 20, 2022
@github-actions github-actions Bot mentioned this pull request Nov 21, 2022
CI Reliability 2022-11-21 nodejs/reliability#435
Open
15 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 21, 2022
@nodejs-github-bot
nodejs-github-bot merged commit b4666c3 into nodejs:main Nov 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2022

Copy link
Copy Markdown
Collaborator

Landed in b4666c3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 22, 2022
CI Reliability 2022-11-22 nodejs/reliability#436
Open
CI Reliability 2022-11-23 nodejs/reliability#437
Open
ruyadorno pushed a commit that referenced this pull request Nov 24, 2022
@tniessen @ruyadorno
doc: add missing documentation for paramEncoding
16643db 
This option has existed ever since generateKeyPair was added in 2019 or
so, but I apparently forgot to document it.

PR-URL: #45523
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@tniessen @danielleadams
doc: add missing documentation for paramEncoding
f817dc5 
This option has existed ever since generateKeyPair was added in 2019 or
so, but I apparently forgot to document it.

PR-URL: #45523
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@tniessen @danielleadams
doc: add missing documentation for paramEncoding
203ca49 
This option has existed ever since generateKeyPair was added in 2019 or
so, but I apparently forgot to document it.

PR-URL: #45523
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@tniessen @danielleadams
doc: add missing documentation for paramEncoding
4aa97cb 
This option has existed ever since generateKeyPair was added in 2019 or
so, but I apparently forgot to document it.

PR-URL: #45523
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@vansergen vansergen mentioned this pull request Nov 14, 2023
[node:crypto]: Add missing paramEncoding option DefinitelyTyped/DefinitelyTyped#67404
Merged
8 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@tniessen @nodejs-github-bot @panva @jasnell @anonrig @cjihrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.