GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add missing trailing commas in addons test by aduh95 · Pull Request #45548 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Nov 20, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
test: add missing trailing commas in addons test
13c54a1
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 20, 2022
daeyeon
daeyeon approved these changes Nov 20, 2022
View reviewed changes
Trott
Trott approved these changes Nov 21, 2022
View reviewed changes
@aduh95 aduh95 added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Nov 21, 2022
@github-actions

github-actions Bot commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.
MoLow and RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Nov 21, 2022
View reviewed changes
RaisinTen
RaisinTen approved these changes Nov 21, 2022
View reviewed changes
@daeyeon daeyeon added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 21, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45548
✔  Done loading data for nodejs/node/pull/45548
----------------------------------- PR info ------------------------------------
Title      test: add missing trailing commas in addons test (#45548)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:addons-test-dangle -> nodejs:main
Labels     test, addons, fast-track, author ready
Commits    1
 - test: add missing trailing commas in addons test
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/45548
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Rich Trott 
Reviewed-By: Moshe Atlow 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45548
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Rich Trott 
Reviewed-By: Moshe Atlow 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 20 Nov 2022 17:45:02 GMT
   ✔  Approvals: 4
   ✔  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/45548#pullrequestreview-1187343978
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45548#pullrequestreview-1187383946
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45548#pullrequestreview-1188167932
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45548#pullrequestreview-1188177801
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3514762851
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daeyeon daeyeon added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Nov 21, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48064/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Nov 21, 2022
View reviewed changes
@aduh95
aduh95 merged commit 4f20c88 into nodejs:main Nov 21, 2022
@aduh95

aduh95 commented Nov 21, 2022

Copy link
Copy Markdown
Contributor Author

Landed in 4f20c88
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the addons-test-dangle branch November 21, 2022 17:40
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@aduh95 @ruyadorno
test: add trailing commas in addons test (#45548)
731e874 
PR-URL: #45548
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
test: add trailing commas in addons test (#45548)
bb1b6e5 
PR-URL: #45548
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@aduh95 @danielleadams
test: add trailing commas in addons test (#45548)
d5b0844 
PR-URL: #45548
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@aduh95 @danielleadams
test: add trailing commas in addons test (#45548)
0efb9d6 
PR-URL: #45548
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@anonrig anonrig anonrig approved these changes
@daeyeon daeyeon daeyeon approved these changes
@MoLow MoLow MoLow approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

addons Issues and PRs related to native addons. author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@aduh95 @nodejs-github-bot @Trott @anonrig @daeyeon @MoLow @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.