GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: use console.error for error case in http2 by deokjinkim · Pull Request #45577 · nodejs/node

Conversation

@deokjinkim

@deokjinkim deokjinkim commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

console.error is more suitable than console.log for error case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@deokjinkim
doc: use console.error for error case in http2
f590bb2 
console.error is more suitable than console.log for error case.
@nodejs-github-bot

nodejs-github-bot commented Nov 22, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. http2 Issues and PRs related to the http2 subsystem. labels Nov 22, 2022
RafaelGSS
RafaelGSS approved these changes Nov 22, 2022
View reviewed changes
santigimeno
santigimeno approved these changes Nov 22, 2022
View reviewed changes
ShogunPanda
ShogunPanda approved these changes Nov 22, 2022
View reviewed changes
daeyeon
daeyeon approved these changes Nov 23, 2022
View reviewed changes
@daeyeon daeyeon added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 23, 2022
@github-actions

github-actions Bot commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @daeyeon. Please 👍 to approve.
RafaelGSS and ShogunPanda reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daeyeon daeyeon added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 23, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 23, 2022
@nodejs-github-bot
nodejs-github-bot merged commit f36768a into nodejs:main Nov 23, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2022

Copy link
Copy Markdown
Collaborator

Landed in f36768a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Nov 24, 2022
@deokjinkim @ruyadorno
doc: use console.error for error case in http2
015842f 
console.error is more suitable than console.log for error case.

PR-URL: #45577
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@deokjinkim @danielleadams
doc: use console.error for error case in http2
b88eb3b 
console.error is more suitable than console.log for error case.

PR-URL: #45577
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@deokjinkim @danielleadams
doc: use console.error for error case in http2
30a8604 
console.error is more suitable than console.log for error case.

PR-URL: #45577
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@deokjinkim @danielleadams
doc: use console.error for error case in http2
5fd88ac 
console.error is more suitable than console.log for error case.

PR-URL: #45577
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes
@santigimeno santigimeno santigimeno approved these changes
@daeyeon daeyeon daeyeon approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. http2 Issues and PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@deokjinkim @nodejs-github-bot @ShogunPanda @santigimeno @daeyeon @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.