GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix typos in test/parallel by deokjinkim · Pull Request #45583 · nodejs/node

Conversation

@deokjinkim

@deokjinkim deokjinkim commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Fix typos in parallel tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 22, 2022
aduh95
aduh95 approved these changes Nov 22, 2022
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 22, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 22, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48092/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Nov 22, 2022
View reviewed changes
Trott
Trott approved these changes Nov 22, 2022
View reviewed changes
cjihrig
cjihrig approved these changes Nov 22, 2022
View reviewed changes
lpinca
lpinca approved these changes Nov 22, 2022
View reviewed changes
@lpinca lpinca added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 22, 2022
@github-actions

github-actions Bot commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.
lpinca, aduh95, daeyeon, RaisinTen, and cola119 reacted with thumbs up emoji
All reactions
  • 👍 5 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen approved these changes Nov 23, 2022
View reviewed changes
ErickWendel
ErickWendel approved these changes Nov 23, 2022
View reviewed changes
@ErickWendel

ErickWendel commented Nov 23, 2022

Copy link
Copy Markdown
Member

I've just scheduled a Rerun for test-asan action as the error is not related to this PR. Let's check if it passes now 🤩
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cola119
cola119 approved these changes Nov 24, 2022
View reviewed changes
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 24, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48160/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 25, 2022
CI Reliability 2022-11-25 nodejs/reliability#439
Open
CI Reliability 2022-11-26 nodejs/reliability#440
Open
CI Reliability 2022-11-27 nodejs/reliability#441
Open
@deokjinkim

deokjinkim commented Nov 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@ErickWendel and @cola119, IMO, CI error is not related to this pr. Could you re-run CI when you are available?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Nov 27, 2022

Copy link
Copy Markdown
Contributor

CI error is not related to this pr. Could you re-run CI when you are available?

The ASan CI is faulty on your branch (for a reason not related to this PR, indeed), the fix has landed in main so you would need to rebase your branch for the CI to turn green. Would you be able to do that? Let us know if you need help or if you would prefer someone else doing it for you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deokjinkim
test: fix typos in test/parallel
162fd7f 
Fix typos in parallel tests.
@deokjinkim
deokjinkim force-pushed the 221123_test_parallel_typo branch from ee6ed6c to 162fd7f Compare November 27, 2022 11:40
@deokjinkim

deokjinkim commented Nov 27, 2022

Copy link
Copy Markdown
Contributor Author

The ASan CI is faulty on your branch (for a reason not related to this PR, indeed), the fix has landed in main so you would need to rebase your branch for the CI to turn green. Would you be able to do that? Let us know if you need help or if you would prefer someone else doing it for you.

Thank you for kind explanation. I rebased this PR.
cola119 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Nov 27, 2022
View reviewed changes
@aduh95 aduh95 removed the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 27, 2022
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 27, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48213/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 28, 2022
CI Reliability 2022-11-28 nodejs/reliability#442
Open
20 tasks
cola119
cola119 approved these changes Nov 28, 2022
View reviewed changes
@cola119 cola119 added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 28, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 28, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 58b60c1 into nodejs:main Nov 28, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 28, 2022

Copy link
Copy Markdown
Collaborator

Landed in 58b60c1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 29, 2022
CI Reliability 2022-11-29 nodejs/reliability#443
Open
CI Reliability 2022-11-30 nodejs/reliability#444
Open
@github-actions github-actions Bot mentioned this pull request Dec 1, 2022
CI Reliability 2022-12-01 nodejs/reliability#445
Open
10 tasks
targos pushed a commit that referenced this pull request Dec 12, 2022
@deokjinkim @targos
test: fix typos in test/parallel
b55bd6e 
Fix typos in parallel tests.

PR-URL: #45583
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
@targos targos mentioned this pull request Dec 12, 2022
v19.3.0 release proposal #45831
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@deokjinkim @danielleadams
test: fix typos in test/parallel
682a71c 
Fix typos in parallel tests.

PR-URL: #45583
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@deokjinkim @danielleadams
test: fix typos in test/parallel
7dbc742 
Fix typos in parallel tests.

PR-URL: #45583
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@deokjinkim @danielleadams
test: fix typos in test/parallel
d3b2252 
Fix typos in parallel tests.

PR-URL: #45583
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@ErickWendel ErickWendel ErickWendel approved these changes
@aduh95 aduh95 aduh95 approved these changes
@cola119 cola119 cola119 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@deokjinkim @nodejs-github-bot @ErickWendel @aduh95 @Trott @lpinca @cjihrig @richardlau @cola119 @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.