GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — repl: do not define `wasi` on global with no flag by cola119 · Pull Request #45595 · nodejs/node

Conversation

cola119 commented Nov 23, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Fixes #45560

In the REPL, prepareMainThreadExecution that updates the canBeRequiredByUsers flag of wasi module according to the flag is called after the internal/process/esm_loader.js load that creates builtinModules depending on the module.canBeRequiredByUsers flag. In this case, wasi.canBeRequiredByUsers is always true so wasi module always can be required by users even if the flag is not set.

node/lib/internal/modules/cjs/loader.js

Lines 217 to 223 in 2a7635f

	const builtinModules = [];
	for (const { 0: id, 1: mod } of BuiltinModule.map) {
	if (mod.canBeRequiredByUsers &&
	BuiltinModule.canBeRequiredWithoutScheme(id)) {
	ArrayPrototypePush(builtinModules, id);
	}
	}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and nomagick reacted with thumbs up emoji

All reactions

👍 2 reactions

nodejs-github-bot added the needs-ci PRs that need a full CI run. label

Nov 23, 2022

cola119 added the repl Issues and PRs related to the REPL subsystem. label

Nov 23, 2022

cola119 changed the title ~~repl: do not defined wasi on global with no flag~~ repl: do not define wasi on global with no flag

Nov 23, 2022

cola119 force-pushed the fix-45560 branch from 2546e42 to 0a9257a Compare

November 23, 2022 12:23

aduh95 reviewed

Nov 23, 2022

View reviewed changes

Comment thread

lib/internal/main/repl.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR approved these changes

Nov 23, 2022

View reviewed changes

Comment thread

lib/internal/main/repl.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

cjihrig approved these changes

Nov 23, 2022

View reviewed changes

aduh95 approved these changes

Nov 23, 2022

View reviewed changes

aduh95 added author ready

PRs with CI started, the required approvals, and no outstanding review comments.

request-ci

Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review.

commit-queue PRs queued for automated landing through the Commit Queue. labels

Nov 23, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 23, 2022

nodejs-github-bot commented Nov 23, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48129/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca approved these changes

Nov 23, 2022

View reviewed changes

nodejs-github-bot commented Nov 23, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48141/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          repl: do not define wasi on global with no flag

45d85ba

cola119 force-pushed the fix-45560 branch from 0a9257a to 45d85ba Compare

November 23, 2022 23:35

aduh95 approved these changes

Nov 23, 2022

View reviewed changes

github-actions Bot mentioned this pull request

Nov 24, 2022

CI Reliability 2022-11-24 nodejs/reliability#438

Open

16 tasks

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 25, 2022

nodejs-github-bot commented Nov 25, 2022

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/45595
✔  Done loading data for nodejs/node/pull/45595
----------------------------------- PR info ------------------------------------
Title      repl: do not define `wasi` on global with no flag (#45595)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     cola119:fix-45560 -> nodejs:main
Labels     repl, author ready, needs-ci
Commits    1
 - repl: do not define `wasi` on global with no flag
Committers 1
 - cola119 
PR-URL: https://github.com/nodejs/node/pull/45595
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45595
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 23 Nov 2022 08:48:35 GMT
   ✔  Approvals: 4
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/45595#pullrequestreview-1191699283
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45595#pullrequestreview-1191760663
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45595#pullrequestreview-1192375682
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45595#pullrequestreview-1192246419
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-23T22:44:37Z: https://ci.nodejs.org/job/node-test-pull-request/48141/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - repl: do not define `wasi` on global with no flag
- Querying data for job/node-test-pull-request/48141/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3546553264

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Nov 25, 2022

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 25, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 25, 2022

nodejs-github-bot commented Nov 25, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48178/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cola119 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 25, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 25, 2022

nodejs-github-bot commented Nov 25, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48182/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Nov 26, 2022

CI Reliability 2022-11-26 nodejs/reliability#440

Open

21 tasks

cola119 removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Nov 26, 2022

cola119 added the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 26, 2022

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 26, 2022

nodejs-github-bot merged commit 5a8895c into nodejs:main

Nov 26, 2022

nodejs-github-bot commented Nov 26, 2022

Copy link

Copy Markdown

Collaborator

Landed in 5a8895c

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cola119 deleted the fix-45560 branch

November 26, 2022 11:16

This was referenced Nov 27, 2022

CI Reliability 2022-11-27 nodejs/reliability#441

Open

CI Reliability 2022-11-28 nodejs/reliability#442

Open

CI Reliability 2022-11-29 nodejs/reliability#443

Open

CI Reliability 2022-11-30 nodejs/reliability#444

Open

This was referenced Dec 1, 2022

CI Reliability 2022-12-01 nodejs/reliability#445

Open

CI Reliability 2022-12-02 nodejs/reliability#446

Open

targos pushed a commit that referenced this pull request

Dec 12, 2022


          repl: do not define wasi on global with no flag

7892e23

PR-URL: #45595
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

targos mentioned this pull request

Dec 12, 2022

v19.3.0 release proposal #45831

Merged

danielleadams mentioned this pull request

Dec 30, 2022

v18.13.0 release proposal #46025

Merged

danielleadams pushed a commit that referenced this pull request

Dec 30, 2022


          repl: do not define wasi on global with no flag

f4ecc87

PR-URL: #45595
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

danielleadams pushed a commit that referenced this pull request

Jan 3, 2023


          repl: do not define wasi on global with no flag

b999983

PR-URL: #45595
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

danielleadams pushed a commit that referenced this pull request

Jan 5, 2023


          repl: do not define wasi on global with no flag

33da978

PR-URL: #45595
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Reviewers

lpinca

lpinca approved these changes

cjihrig

cjihrig approved these changes

BridgeAR

BridgeAR approved these changes

aduh95

aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

needs-ci

PRs that need a full CI run.

repl

Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wasi incorrectly defined on global

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

cola119 commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 23, 2022

Uh oh!

nodejs-github-bot commented Nov 23, 2022

Uh oh!

nodejs-github-bot commented Nov 25, 2022

Uh oh!

nodejs-github-bot commented Nov 25, 2022

Uh oh!

nodejs-github-bot commented Nov 25, 2022

Uh oh!

nodejs-github-bot commented Nov 26, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cola119 commented Nov 23, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.