GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: use structuredClone instead of v8 by anonrig · Pull Request #45611 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Nov 24, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This pull request replaces deserialize(serialize(value)) with structuredClone(value) due to performance.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and vrshowdown reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@anonrig
stream: use structuredClone instead of v8
8abc1ed
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Nov 24, 2022
ErickWendel
ErickWendel approved these changes Nov 24, 2022
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 24, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48164/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Nov 24, 2022
View reviewed changes
Comment thread lib/internal/webstreams/readablestream.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added dont-land-on-v14.x labels Nov 24, 2022
@anonrig
fixup! stream: use structuredClone instead of v8
26f28d4
aduh95
aduh95 approved these changes Nov 24, 2022
View reviewed changes
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 24, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48167/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Nov 24, 2022
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 25, 2022
@tniessen

tniessen commented Nov 25, 2022

Copy link
Copy Markdown
Member

It would be cool not to have empty commit messages and empty PR descriptions. What is being done or how it is being done is often less relevant than the reasoning behind it.
anonrig, BridgeAR, and cjihrig reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sindresorhus
sindresorhus reviewed Nov 25, 2022
View reviewed changes
Comment thread lib/internal/webstreams/readablestream.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
fixup! stream: use structuredClone instead of v8
9c76a8b
@anonrig

anonrig commented Nov 25, 2022

Copy link
Copy Markdown
Member Author

It would be cool not to have empty commit messages and empty PR descriptions. What is being done or how it is being done is often less relevant than the reasoning behind it.

Thanks for the feedback. I'll add descriptions from now on. I've also updated the description for this pull request.
tniessen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 26, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45611
✔  Done loading data for nodejs/node/pull/45611
----------------------------------- PR info ------------------------------------
Title      stream: use structuredClone instead of v8 (#45611)
Author     Yagiz Nizipli  (@anonrig)
Branch     anonrig:stream/structured-clone -> nodejs:main
Labels     author ready, needs-ci, dont-land-on-v14.x, dont-land-on-v16.x, web streams
Commits    3
 - stream: use structuredClone instead of v8
 - fixup! stream: use structuredClone instead of v8
 - fixup! stream: use structuredClone instead of v8
Committers 1
 - Yagiz Nizipli 
PR-URL: https://github.com/nodejs/node/pull/45611
Reviewed-By: Erick Wendel 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45611
Reviewed-By: Erick Wendel 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 24 Nov 2022 16:56:34 GMT
   ✔  Approvals: 3
   ✔  - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/45611#pullrequestreview-1193461926
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45611#pullrequestreview-1193532434
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45611#pullrequestreview-1193580550
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-24T18:52:43Z: https://ci.nodejs.org/job/node-test-pull-request/48167/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - fixup! stream: use structuredClone instead of v8
- Querying data for job/node-test-pull-request/48167/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3554598277
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 26, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 26, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48200/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Nov 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 27, 2022
@nodejs-github-bot
nodejs-github-bot merged commit dda7a21 into nodejs:main Nov 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2022

Copy link
Copy Markdown
Collaborator

Landed in dda7a21
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Dec 12, 2022
@anonrig @targos
stream: use structuredClone instead of v8
56eee72 
PR-URL: #45611
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Dec 12, 2022
v19.3.0 release proposal #45831
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig @danielleadams
stream: use structuredClone instead of v8
4e9521e 
PR-URL: #45611
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@anonrig @danielleadams
stream: use structuredClone instead of v8
122c51b 
PR-URL: #45611
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@anonrig @danielleadams
stream: use structuredClone instead of v8
0f166e4 
PR-URL: #45611
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@ErickWendel ErickWendel ErickWendel approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@sindresorhus sindresorhus sindresorhus left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@anonrig @nodejs-github-bot @tniessen @sindresorhus @lpinca @ErickWendel @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.