GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: don't parse TAP from stderr by cjihrig · Pull Request #45618 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

This commit stops the test runner CLI from parsing child process stderr as TAP. Per the TAP spec, TAP can only come from stdout. To avoid losing stderr data, those logs are injected into the parser as unknown tokens so that they are output as TAP comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cjihrig
test_runner: don't parse TAP from stderr
58e5382 
This commit stops the test runner CLI from parsing child
process stderr as TAP. Per the TAP spec, TAP can only come from
stdout. To avoid losing stderr data, those logs are injected
into the parser as unknown tokens so that they are output as
comments.
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. util Issues and PRs related to the built-in util module. labels Nov 25, 2022
MoLow
MoLow reviewed Nov 25, 2022
View reviewed changes
Comment thread lib/internal/test_runner/runner.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Nov 26, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48209/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig cjihrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. and removed needs-ci PRs that need a full CI run. labels Nov 28, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 28, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 28, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45618
✔  Done loading data for nodejs/node/pull/45618
----------------------------------- PR info ------------------------------------
Title      test_runner: don't parse TAP from stderr (#45618)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:runner-2 -> nodejs:main
Labels     util, author ready, dont-land-on-v14.x, commit-queue-rebase, test_runner
Commits    1
 - test_runner: don't parse TAP from stderr
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/45618
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45618
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 25 Nov 2022 03:02:08 GMT
   ✔  Approvals: 1
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45618#pullrequestreview-1194906306
   ✖  This PR needs to wait 96 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-27T18:46:00Z: https://ci.nodejs.org/job/node-test-pull-request/48209/
- Querying data for job/node-test-pull-request/48209/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3561196202
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Nov 29, 2022
@cjihrig cjihrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 2, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 2, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45618
✔  Done loading data for nodejs/node/pull/45618
----------------------------------- PR info ------------------------------------
Title      test_runner: don't parse TAP from stderr (#45618)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:runner-2 -> nodejs:main
Labels     util, author ready, dont-land-on-v14.x, test_runner
Commits    1
 - test_runner: don't parse TAP from stderr
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/45618
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45618
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 25 Nov 2022 03:02:08 GMT
   ✔  Approvals: 1
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45618#pullrequestreview-1194906306
   ✖  This PR needs to wait 0 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-28T02:37:28Z: https://ci.nodejs.org/job/node-test-pull-request/48209/
- Querying data for job/node-test-pull-request/48209/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3598466504
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig cjihrig added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Dec 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 2, 2022
@nodejs-github-bot
nodejs-github-bot merged commit cc2732d into nodejs:main Dec 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 2, 2022

Copy link
Copy Markdown
Collaborator

Landed in cc2732d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig
cjihrig deleted the runner-2 branch December 2, 2022 03:13
targos pushed a commit that referenced this pull request Dec 12, 2022
@cjihrig @targos
test_runner: don't parse TAP from stderr
3e48536 
This commit stops the test runner CLI from parsing child
process stderr as TAP. Per the TAP spec, TAP can only come from
stdout. To avoid losing stderr data, those logs are injected
into the parser as unknown tokens so that they are output as
comments.

PR-URL: #45618
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request Dec 12, 2022
v19.3.0 release proposal #45831
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@cjihrig @danielleadams
test_runner: don't parse TAP from stderr
f761db9 
This commit stops the test runner CLI from parsing child
process stderr as TAP. Per the TAP spec, TAP can only come from
stdout. To avoid losing stderr data, those logs are injected
into the parser as unknown tokens so that they are output as
comments.

PR-URL: #45618
Reviewed-By: Moshe Atlow <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@cjihrig @danielleadams
test_runner: don't parse TAP from stderr
ed9246f 
This commit stops the test runner CLI from parsing child
process stderr as TAP. Per the TAP spec, TAP can only come from
stdout. To avoid losing stderr data, those logs are injected
into the parser as unknown tokens so that they are output as
comments.

PR-URL: #45618
Reviewed-By: Moshe Atlow <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@cjihrig @danielleadams
test_runner: don't parse TAP from stderr
a327a78 
This commit stops the test runner CLI from parsing child
process stderr as TAP. Per the TAP spec, TAP can only come from
stdout. To avoid losing stderr data, those logs are injected
into the parser as unknown tokens so that they are output as
comments.

PR-URL: #45618
Reviewed-By: Moshe Atlow <[email protected]>
@MoLow MoLow mentioned this pull request May 15, 2023
Test Runner: delegate arbitrary output formatting to each reporter #48011
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test_runner Issues and PRs related to the test runner subsystem. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cjihrig @nodejs-github-bot @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.