GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||
GeezerVison is showing github.com — doc: fix actual result of example is different in events by deokjinkim · Pull Request #45656 · nodejs/node Conversation
|
|
Just ran with the below code example (separately, we should probably update this specific code example to actually be runnable with the below code) and got the updated output. const EventEmitter = require('node:events'); class MyEmitter extends EventEmitter {}; const myEmitter = new MyEmitter(); myEmitter.on('event', function(a, b) { console.log(a, b, this, this === myEmitter); }); myEmitter.emit('event', 'a', 'b'); |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Nit: the commit message title needs to start with an imperative verb to meet the guideline below. This isn't a blocker since it could be fixed by someone when landing the PR. However, it can be fixed also by a force push. node/doc/contributing/pull-requests.md Lines 168 to 171 in a1c62cf
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Change of events internal may be not reflected yet.
1ed643b to
56f9768
Compare
@daeyeon Thank you for kind explanation and remind. Updated commit message title starting with an imperative verb. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in ab064d1 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.