GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: update AUTHORS info for nstepien by nstepien · Pull Request #45692 · nodejs/node

Conversation

@nstepien

@nstepien nstepien commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 30, 2022
@nstepien nstepien changed the title Update AUTHORS to use my name meta: Update AUTHORS to use my name Nov 30, 2022
@aduh95 aduh95 changed the title meta: Update AUTHORS to use my name meta: update AUTHORS info for nstepien Nov 30, 2022
@aduh95

aduh95 commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Can you add an entry in the .mailmap file, and then run tools/update-authors.mjs script? As is, this change would be overwritten the next time we run the script.
Optionally if you could amend the commit message so it complies with our guidelines (e.g. to meta: update AUTHORS info for nstepien) and force push, that'd be great – otherwise it can be done by whoever is landing the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nstepien
meta: update AUTHORS info for nstepien
0ce2633
@nstepien

nstepien commented Nov 30, 2022

Copy link
Copy Markdown
Contributor Author

@aduh95 Done, thank you for your guidance.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Nov 30, 2022
View reviewed changes
Trott
Trott approved these changes Nov 30, 2022
View reviewed changes
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 30, 2022
@github-actions

github-actions Bot commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Nov 30, 2022
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 30, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 2589fb1 into nodejs:main Nov 30, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2022

Copy link
Copy Markdown
Collaborator

Landed in 2589fb1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nstepien
nstepien deleted the patch-1 branch November 30, 2022 22:36
targos pushed a commit that referenced this pull request Dec 12, 2022
@nstepien @targos
meta: update AUTHORS info for nstepien
eb9a383 
PR-URL: #45692
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Dec 12, 2022
v19.3.0 release proposal #45831
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nstepien @danielleadams
meta: update AUTHORS info for nstepien
db1be1d 
PR-URL: #45692
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@nstepien @danielleadams
meta: update AUTHORS info for nstepien
775f659 
PR-URL: #45692
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@nstepien @danielleadams
meta: update AUTHORS info for nstepien
a55d1e8 
PR-URL: #45692
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nstepien @aduh95 @nodejs-github-bot @Trott @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.