GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: make structuredClone work for process.env by bnoordhuis · Pull Request #45698 · nodejs/node

Conversation

@bnoordhuis

@bnoordhuis bnoordhuis commented Dec 1, 2022

Copy link
Copy Markdown
Member

Fixes: #45380

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji bricss reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Dec 1, 2022
@bnoordhuis bnoordhuis mentioned this pull request Dec 1, 2022
structuredClone does not work on process.env #45380
Closed
@bnoordhuis
bnoordhuis force-pushed the fix45380 branch from f20e814 to 7816dad Compare December 1, 2022 13:48
anonrig
anonrig reviewed Dec 1, 2022
View reviewed changes
Comment thread src/node_env_var.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax reviewed Dec 2, 2022
View reviewed changes
Comment thread src/node_env_var.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/node_messaging.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/node_messaging.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis
src: make structuredClone work for process.env
bec0122 
Fixes: nodejs#45380
@bnoordhuis
bnoordhuis force-pushed the fix45380 branch from 7816dad to bec0122 Compare December 7, 2022 09:36
@bnoordhuis

bnoordhuis commented Dec 7, 2022

Copy link
Copy Markdown
Member Author

Thanks for the review, Anna. PTAL if you have a moment.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Dec 7, 2022
View reviewed changes
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 7, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48317/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Dec 8, 2022
CI Reliability 2022-12-08 nodejs/reliability#451
Open
8 tasks
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48346/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Dec 8, 2022
View reviewed changes
This was referenced Dec 9, 2022
CI Reliability 2022-12-09 nodejs/reliability#452
Open
CI Reliability 2022-12-10 nodejs/reliability#453
Open
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48398/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 10, 2022
@github-actions github-actions Bot mentioned this pull request Dec 11, 2022
CI Reliability 2022-12-11 nodejs/reliability#454
Open
11 tasks
@addaleax addaleax added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 11, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 8273320 into nodejs:main Dec 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2022

Copy link
Copy Markdown
Collaborator

Landed in 8273320
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Dec 12, 2022
CI Reliability 2022-12-12 nodejs/reliability#455
Open
11 tasks
targos pushed a commit that referenced this pull request Dec 12, 2022
@bnoordhuis @targos
src: make structuredClone work for process.env
a172601 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request Dec 12, 2022
v19.3.0 release proposal #45831
Merged
@github-actions github-actions Bot mentioned this pull request Dec 13, 2022
CI Reliability 2022-12-13 nodejs/reliability#456
Open
13 tasks
targos pushed a commit that referenced this pull request Dec 13, 2022
@bnoordhuis @targos
src: make structuredClone work for process.env
b35ebeb 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@bnoordhuis @danielleadams
src: make structuredClone work for process.env
b99e77b 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@bnoordhuis @danielleadams
src: make structuredClone work for process.env
b88ee54 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@bnoordhuis @danielleadams
src: make structuredClone work for process.env
f995a06 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@anonrig anonrig anonrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

structuredClone does not work on process.env

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bnoordhuis @nodejs-github-bot @addaleax @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.