GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: refactor `tap_lexer` to use more primordials by aduh95 · Pull Request #45744 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
test_runner: refactor tap_lexer to use more primordials
10544ef
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 5, 2022
MoLow
MoLow approved these changes Dec 5, 2022
View reviewed changes
@aduh95
fixup! test_runner: refactor tap_lexer to use more primordials
9e1e56f
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Dec 5, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 5, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48296/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Dec 5, 2022
View reviewed changes
aduh95
aduh95 commented Dec 6, 2022
View reviewed changes
Comment thread lib/internal/test_runner/tap_lexer.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
Update lib/internal/test_runner/tap_lexer.js
350ce5f
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Dec 6, 2022
@github-actions github-actions Bot mentioned this pull request Dec 7, 2022
CI Reliability 2022-12-07 nodejs/reliability#450
Open
10 tasks
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48316/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Dec 8, 2022
CI Reliability 2022-12-08 nodejs/reliability#451
Open
8 tasks
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48359/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Dec 9, 2022
CI Reliability 2022-12-09 nodejs/reliability#452
Open
CI Reliability 2022-12-10 nodejs/reliability#453
Open
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48391/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Dec 11, 2022
CI Reliability 2022-12-11 nodejs/reliability#454
Open
11 tasks
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48415/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Dec 12, 2022
CI Reliability 2022-12-12 nodejs/reliability#455
Open
11 tasks
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 12, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 12, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45744
✔  Done loading data for nodejs/node/pull/45744
----------------------------------- PR info ------------------------------------
Title      test_runner: refactor `tap_lexer` to use more primordials (#45744)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:tap_lexer-primordials -> nodejs:main
Labels     author ready, needs-ci, dont-land-on-v14.x, commit-queue-squash, test_runner
Commits    3
 - test_runner: refactor `tap_lexer` to use more primordials
 - fixup! test_runner: refactor `tap_lexer` to use more primordials
 - Update lib/internal/test_runner/tap_lexer.js
Committers 2
 - Antoine du Hamel 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/45744
Reviewed-By: Moshe Atlow 
Reviewed-By: Colin Ihrig 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45744
Reviewed-By: Moshe Atlow 
Reviewed-By: Colin Ihrig 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - Update lib/internal/test_runner/tap_lexer.js
   ℹ  This PR was created on Mon, 05 Dec 2022 11:18:28 GMT
   ✔  Approvals: 2
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45744#pullrequestreview-1204376128
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45744#pullrequestreview-1204637115
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-12-11T22:30:29Z: https://ci.nodejs.org/job/node-test-pull-request/48415/
- Querying data for job/node-test-pull-request/48415/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3671541884
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 2483da7 into nodejs:main Dec 12, 2022
@aduh95

aduh95 commented Dec 12, 2022

Copy link
Copy Markdown
Contributor Author

Landed in 2483da7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the tap_lexer-primordials branch December 12, 2022 06:31
targos pushed a commit that referenced this pull request Dec 12, 2022
@aduh95 @targos
test_runner: refactor tap_lexer to use more primordials
32fec7a 
PR-URL: #45744
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Dec 12, 2022
v19.3.0 release proposal #45831
Merged
@github-actions github-actions Bot mentioned this pull request Dec 13, 2022
CI Reliability 2022-12-13 nodejs/reliability#456
Open
13 tasks
targos pushed a commit that referenced this pull request Dec 13, 2022
@aduh95 @targos
test_runner: refactor tap_lexer to use more primordials
424419c 
PR-URL: #45744
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@github-actions github-actions Bot mentioned this pull request Dec 14, 2022
CI Reliability 2022-12-14 nodejs/reliability#457
Open
12 tasks
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
test_runner: refactor tap_lexer to use more primordials
10cd9c1 
PR-URL: #45744
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@aduh95 @danielleadams
test_runner: refactor tap_lexer to use more primordials
24e2a4f 
PR-URL: #45744
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@aduh95 @danielleadams
test_runner: refactor tap_lexer to use more primordials
daeab77 
PR-URL: #45744
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@aduh95 @MoLow
chore: refactor tap_lexer to use more primordials
4e778bc 
PR-URL: nodejs/node#45744
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
(cherry picked from commit 2483da743cbb48f31c6b3f8cb186d89f31d73611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aduh95 @nodejs-github-bot @cjihrig @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.