GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: refactor `tap_parser` to use more primordials by aduh95 · Pull Request #45745 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
test_runner: refactor tap_parser to use more primordials
e24478e
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 5, 2022
MoLow
MoLow approved these changes Dec 5, 2022
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Dec 5, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 5, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48295/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Dec 5, 2022
View reviewed changes
VoltrexKeyva
VoltrexKeyva reviewed Dec 5, 2022
View reviewed changes
Comment thread lib/internal/test_runner/tap_parser.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr previously requested changes Dec 6, 2022
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, "request changes"ing so no one lands this by mistake without benchmarks showing no regression.

If benchmarks were run - feel free to treat this "request changes" as a "lgtm"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95

aduh95 commented Dec 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@benjamingr we don't have benchmarks for the test runner, and IMO robustness is much more important than performance for a test runner anyway. (also it seems unlikely to me that this change would impact perf by any significant manner, but I don't have any data to back this up)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 @VoltrexKeyva
Update lib/internal/test_runner/tap_parser.js
d339cb8 
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Dec 6, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48306/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Dec 6, 2022
View reviewed changes
This was referenced Dec 7, 2022
CI Reliability 2022-12-07 nodejs/reliability#450
Open
CI Reliability 2022-12-08 nodejs/reliability#451
Open
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48358/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Dec 9, 2022
CI Reliability 2022-12-09 nodejs/reliability#452
Open
5 tasks
@cjihrig cjihrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Dec 9, 2022
This was referenced Dec 10, 2022
CI Reliability 2022-12-10 nodejs/reliability#453
Open
CI Reliability 2022-12-11 nodejs/reliability#454
Open
@cjihrig
cjihrig dismissed benjamingr’s stale review December 11, 2022 22:31

Dismissing per #45745 (comment)

@cjihrig cjihrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 11, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 7a42a20 into nodejs:main Dec 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2022

Copy link
Copy Markdown
Collaborator

Landed in 7a42a20
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the tap_parser-primordials branch December 11, 2022 23:16
targos pushed a commit that referenced this pull request Dec 12, 2022
@aduh95 @targos
test_runner: refactor tap_parser to use more primordials
27331e4 
PR-URL: #45745
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request Dec 12, 2022
v19.3.0 release proposal #45831
Merged
targos pushed a commit that referenced this pull request Dec 13, 2022
@aduh95 @targos
test_runner: refactor tap_parser to use more primordials
ffc0f3d 
PR-URL: #45745
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
test_runner: refactor tap_parser to use more primordials
ae56544 
PR-URL: #45745
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@aduh95 @danielleadams
test_runner: refactor tap_parser to use more primordials
3cee3ca 
PR-URL: #45745
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@aduh95 @danielleadams
test_runner: refactor tap_parser to use more primordials
16cb2b6 
PR-URL: #45745
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@aduh95 @MoLow
chore: refactor tap_parser to use more primordials
9b49978 
PR-URL: nodejs/node#45745
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
(cherry picked from commit 7a42a206ac37d95060640b4812aaef32535937e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@MoLow MoLow MoLow approved these changes
@benjamingr benjamingr benjamingr left review comments
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@aduh95 @nodejs-github-bot @benjamingr @anonrig @cjihrig @MoLow @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.