GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v14.21.2 proposal by richardlau · Pull Request #45775 · nodejs/node

Conversation

@richardlau

@richardlau richardlau commented Dec 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

2022-12-13, Version 14.21.2 'Fermium' (LTS), @richardlau

Notable Changes

OpenSSL 1.1.1s

This update is a bugfix release and does not address any security
vulnerabilities.

Root certificates updated to NSS 3.85

Certificates added:

  • Autoridad de Certificacion Firmaprofesional CIF A62634068
  • Certainly Root E1
  • Certainly Root R1
  • D-TRUST BR Root CA 1 2020
  • D-TRUST EV Root CA 1 2020
  • DigiCert TLS ECC P384 Root G5
  • DigiCert TLS RSA4096 Root G5
  • E-Tugra Global Root CA ECC v3
  • E-Tugra Global Root CA RSA v3
  • HiPKI Root CA - G1
  • ISRG Root X2
  • Security Communication ECC RootCA1
  • Security Communication RootCA3
  • Telia Root CA v2
  • vTrus ECC Root CA
  • vTrus Root CA

Certificates removed:

  • Cybertrust Global Root
  • DST Root CA X3
  • GlobalSign Root CA - R2
  • Hellenic Academic and Research Institutions RootCA 2011

Time zone update to 2022f

Time zone data has been updated to 2022f. This includes changes to Daylight
Savings Time (DST) for Fiji and Mexico. For more information, see
https://mm.icann.org/pipermail/tz-announce/2022-October/000075.html.

Commits

  • [436a596e99] - crypto: update root certificates (Luigi Pinca) #45490
  • [4b422d34af] - deps: V8: cherry-pick d2db7fa7f786 (Richard Lau) #45785
  • [625f4bf3a9] - deps: update corepack to 0.15.1 (Node.js GitHub Bot) #45331
  • [48a9810de8] - deps: update corepack to 0.15.0 (Node.js GitHub Bot) #45235
  • [9f4e64b603] - deps: update timezone to 2022f (Richard Lau) #45521
  • [f297b6bd21] - deps: update archs files for OpenSSL-1.1.1s (RafaelGSS) #45272
  • [11629fef15] - deps: upgrade openssl sources to 1.1.1s (RafaelGSS) #45272
  • [c3a90c4b44] - http2: fix memory leak when nghttp2 hd threshold is reached (rogertyang) #41502
  • [785dc3efee] - module: cjs-module-lexer WebAssembly fallback (Guy Bedford) #43612
  • [2dbeb889f6] - node-api: handle no support for external buffers (Michael Dawson) #45181
  • [5b2ea124f3] - test: add test to validate changelogs for releases (Richard Lau) #45325
  • [f13f889956] - test: add a test to ensure the correctness of timezone upgrades (Darshan Sen) #45299
  • [5608e6fa72] - tools: update certdata.txt (Luigi Pinca) #45490
  • [d6f1d7107b] - tools: have test-asan use ubuntu-20.04 (Filip Skokan) #45581
  • [370a00f737] - tools: make license-builder.sh comply with shellcheck 0.8.0 (Rich Trott) #41258

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
RafaelGSS and others added 14 commits November 9, 2022 12:38
@RafaelGSS
deps: upgrade openssl sources to 1.1.1s
11629fe
This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1s.tar.gz
    $ mv openssl-1.1.1s openssl
    $ git add --all openssl
    $ git commit openssl

PR-URL: #45272
Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-November/000242.html
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS
deps: update archs files for OpenSSL-1.1.1s
f297b6b
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
   $ make -C deps/openssl/config
   $ git add deps/openssl/config/archs
   $ git add deps/openssl/openssl/include/crypto/bn_conf.h
   $ git add deps/openssl/openssl/include/crypto/dso_conf.h
   $ git add deps/openssl/openssl/include/openssl/opensslconf.h
   $ git commit

PR-URL: #45272
Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-November/000242.html
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@Trott @richardlau
tools: make license-builder.sh comply with shellcheck 0.8.0
370a00f
Fixes for SC2312 added in shellcheck 0.8.0.

PR-URL: #41258
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@panva @richardlau
tools: have test-asan use ubuntu-20.04
d6f1d71
PR-URL: #45581
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ywave620 @richardlau
http2: fix memory leak when nghttp2 hd threshold is reached
c3a90c4
Refs: #45295
PR-URL: #41502
Backport-PR-URL: #45310
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@RaisinTen @richardlau
test: add a test to ensure the correctness of timezone upgrades
f13f889
Currently, there's no way to know if a timezone upgrade PR is correct
without building and testing the change locally. This change provides a
solution for that.

Tested in RaisinTen#4.

Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #45299
Backport-PR-URL: #45521
Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: #45276
@richardlau
deps: update timezone to 2022f
9f4e64b
PR-URL: #45521
Fixes: #45276
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@nodejs-github-bot @richardlau
deps: update corepack to 0.15.0
48a9810
PR-URL: #45235
Backport-PR-URL: #45245
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@nodejs-github-bot @richardlau
deps: update corepack to 0.15.1
625f4bf
PR-URL: #45331
Backport-PR-URL: #45245
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@guybedford @richardlau
module: cjs-module-lexer WebAssembly fallback
785dc3e
PR-URL: #43612
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@mhdawson @richardlau
node-api: handle no support for external buffers
2dbeb88
Refs: electron/electron#35801
Refs: nodejs/abi-stable-node#441

Electron recently dropped support for external
buffers. Provide a way for addon authors to:
- hide the methods to create external buffers so they can
  avoid using them if they want the broadest compatibility.
- call the methods that create external buffers at runtime
  to check if external buffers are supported and either
  use them or not based on the return code.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #45181
Backport-PR-URL: #45616
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@lpinca @richardlau
tools: update certdata.txt
5608e6f
This is the certdata.txt[0] from NSS 3.85, released on 2022-11-10.

This is the version of NSS that will ship in Firefox 108 on
2022-12-13.

[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_85_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: #45490
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@lpinca @richardlau
crypto: update root certificates
436a596
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.

Certificates added:
- Autoridad de Certificacion Firmaprofesional CIF A62634068
- Certainly Root E1
- Certainly Root R1
- D-TRUST BR Root CA 1 2020
- D-TRUST EV Root CA 1 2020
- DigiCert TLS ECC P384 Root G5
- DigiCert TLS RSA4096 Root G5
- E-Tugra Global Root CA ECC v3
- E-Tugra Global Root CA RSA v3
- HiPKI Root CA - G1
- ISRG Root X2
- Security Communication ECC RootCA1
- Security Communication RootCA3
- Telia Root CA v2
- vTrus ECC Root CA
- vTrus Root CA

Certificates removed:
- Cybertrust Global Root
- DST Root CA X3
- GlobalSign Root CA - R2
- Hellenic Academic and Research Institutions RootCA 2011

PR-URL: #45490
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@richardlau
test: add test to validate changelogs for releases
5b2ea12
Add a new test to check that the changelog files have been correctly
updated for releases.

PR-URL: #45325
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 7, 2022
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v14.x labels Dec 7, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 7, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
RafaelGSS
RafaelGSS approved these changes Dec 8, 2022
View reviewed changes
@richardlau richardlau mentioned this pull request Dec 8, 2022
[v14.x] deps: V8: cherry-pick d2db7fa7f786 #45785
Closed
richardlau added 2 commits December 8, 2022 11:52
@richardlau
deps: V8: cherry-pick d2db7fa7f786
4b422d3
Original commit message:

    [Intl] Fix nb / no fallback

    ICU 69 moved content of nb resources to no and let
    nb fallback to no. This break our original design of checking
    locale availability. Hard wire to check on no if nb fail for now
    until we come out with a better fix.

    Bug: chromium:1215606
    Change-Id: I831529d29590cc643ee0109fb2ce8948dac75613
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3068010
    Commit-Queue: Frank Tang <[email protected]>
    Reviewed-by: Shu-yu Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#76044}

Refs: v8/v8@d2db7fa
PR-URL: #45785
Fixes: #45784
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@richardlau
2022-12-13, Version 14.21.2 'Fermium' (LTS)
92caea6
Notable changes:

OpenSSL 1.1.1s
Root certificates updated to NSS 3.85
Time zone update to 2022f

PR-URL: #45775
@richardlau
richardlau force-pushed the v14.21.2-proposal branch from 0ed4ad5 to 92caea6 Compare December 8, 2022 17:51
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 8, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 8, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022 •
edited by richardlau
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48354/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/5044/

CITGM:

  • Previous release: https://ci.nodejs.org/job/citgm-smoker/3055/
  • This PR: https://ci.nodejs.org/view/job/citgm-smoker/3056/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anonrig

anonrig commented Dec 8, 2022

Copy link
Copy Markdown
Member

I see that utf8 performance improvements are missing from this release. Can we add the performance improvements to this release? TextEncoder and TextDecoder is highly used path for most applications.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau

richardlau commented Dec 8, 2022

Copy link
Copy Markdown
Member Author

I see that utf8 performance improvements are missing from this release. Can we add the performance improvements to this release? TextEncoder and TextDecoder is highly used path for most applications.

No, Node.js 14 is in maintenance and we're trying to keep the number of changes down. The emphasis for maintenance is on stability. See https://github.com/nodejs/Release#release-phases:

Maintenance - Critical bug fixes and security updates. New features may be added at the discretion of the LTS team - typically only in cases where the new feature supports migration to later release lines.

I would generally only consider a change for performance if an earlier release in the same release line regressed performance significantly.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau mentioned this pull request Dec 9, 2022
CVE-2022-35256 (llhttp) found on v14.x nodejs/nodejs-dependency-vuln-assessments#92
Closed
This was referenced Dec 10, 2022
CI Reliability 2022-12-10 nodejs/reliability#453
Open
CI Reliability 2022-12-11 nodejs/reliability#454
Open
CI Reliability 2022-12-12 nodejs/reliability#455
Open
@richardlau

richardlau commented Dec 13, 2022

Copy link
Copy Markdown
Member Author

Release build on 92caea6: https://ci-release.nodejs.org/job/iojs+release/9005/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau added a commit that referenced this pull request Dec 13, 2022
@richardlau
Working on v14.21.3
1516019
PR-URL: #45775
@richardlau
richardlau merged commit 92caea6 into v14.x Dec 13, 2022
@richardlau
richardlau deleted the v14.21.2-proposal branch December 13, 2022 12:47
richardlau added a commit that referenced this pull request Dec 13, 2022
@richardlau
2022-12-13, Version 14.21.2 'Fermium' (LTS)
c7946b1
Notable changes:

OpenSSL 1.1.1s
Root certificates updated to NSS 3.85
Time zone update to 2022f

PR-URL: #45775
@richardlau richardlau mentioned this pull request Dec 13, 2022
Blog: v14.21.2 release post nodejs/nodejs.org#4970
Merged
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Dec 13, 2022
@richardlau
Blog: v14.21.2 release post
69db874
Refs: nodejs/node#45775
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Dec 13, 2022
@richardlau
Blog: v14.21.2 release post (#4970)
512269d
Refs: nodejs/node#45775
richardlau added a commit to richardlau/node-1 that referenced this pull request Dec 13, 2022
@richardlau
doc: clarify release notes for Node.js 14.21.2
d1b5f7f
Refs: nodejs#45775
nodejs-github-bot pushed a commit that referenced this pull request Dec 21, 2022
@richardlau @nodejs-github-bot
doc: clarify release notes for Node.js 14.21.2
533c651
Refs: #45775
PR-URL: #45846
Refs: nodejs/nodejs.org#4972
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
richardlau added a commit that referenced this pull request Dec 21, 2022
@richardlau
doc: clarify release notes for Node.js 14.21.2
d73ea4d
Refs: #45775
PR-URL: #45846
Refs: nodejs/nodejs.org#4972
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dependencies PRs that add, update, or configure Node.js dependencies. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@richardlau @nodejs-github-bot @anonrig @RafaelGSS @Trott @panva @ywave620 @RaisinTen @guybedford @mhdawson @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.