GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: V8: cherry-pick bc831f8ba33b by anonrig · Pull Request #45788 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Dec 8, 2022

Copy link
Copy Markdown
Member

Referencing #45701, this commit from v8 can leverage different use cases (for example wasm), and I believe it shouldn't be blocked with my encodeInto experiment.

Original commit message:

[fastcall] Implement support for onebyte string arguments

This CL adds one byte string specialization support for fast API call arguments.
It introduces a kOneByteString variant to CTypeInfo.

We see a ~6x improvement in Deno's TextEncoder#encode microbenchmark.
Rendered results: https://divy-v8-patches.deno.dev/

Bug: chromium:1052746
Change-Id: I47c3a9e101cd18ddc6ad58f627db3a34231b60f7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4036884
Reviewed-by: Toon Verwaest <[email protected]>
Reviewed-by: Maya Lekova <[email protected]>
Commit-Queue: Maya Lekova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#84552}

Refs: v8/v8@bc831f8

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@anonrig
deps: V8: cherry-pick bc831f8ba33b
69ff31a 
Original commit message:

    [fastcall] Implement support for onebyte string arguments

    This CL adds one byte string specialization support for fast API call arguments.
    It introduces a kOneByteString variant to CTypeInfo.

    We see a ~6x improvement in Deno's TextEncoder#encode microbenchmark.
    Rendered results: https://divy-v8-patches.deno.dev/

    Bug: chromium:1052746
    Change-Id: I47c3a9e101cd18ddc6ad58f627db3a34231b60f7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4036884
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Maya Lekova <[email protected]>
    Commit-Queue: Maya Lekova <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#84552}

Refs: v8/v8@bc831f8
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Dec 8, 2022
addaleax
addaleax approved these changes Dec 8, 2022
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Dec 8, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 8, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48356/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5045/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5045/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5045/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48360/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gengjiawen
gengjiawen approved these changes Dec 9, 2022
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 9, 2022
daeyeon
daeyeon approved these changes Dec 9, 2022
View reviewed changes
@gengjiawen gengjiawen added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 9, 2022
@github-actions

github-actions Bot commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.
gengjiawen and daeyeon reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 9, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45788
✔  Done loading data for nodejs/node/pull/45788
----------------------------------- PR info ------------------------------------
Title      deps: V8: cherry-pick bc831f8ba33b (#45788)
Author     Yagiz Nizipli  (@anonrig)
Branch     anonrig:v8/fast-api-string -> nodejs:main
Labels     build, v8 engine, fast-track, author ready, needs-ci
Commits    1
 - deps: V8: cherry-pick bc831f8ba33b
Committers 1
 - Yagiz Nizipli 
PR-URL: https://github.com/nodejs/node/pull/45788
Refs: https://github.com/v8/v8/commit/bc831f8ba33b79e2eb670faf1f84c4e39aeb0f9f
Reviewed-By: Anna Henningsen 
Reviewed-By: Jiawen Geng 
Reviewed-By: Daeyeon Jeong 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45788
Refs: https://github.com/v8/v8/commit/bc831f8ba33b79e2eb670faf1f84c4e39aeb0f9f
Reviewed-By: Anna Henningsen 
Reviewed-By: Jiawen Geng 
Reviewed-By: Daeyeon Jeong 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 08 Dec 2022 15:13:09 GMT
   ✔  Approvals: 3
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/45788#pullrequestreview-1210642814
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/45788#pullrequestreview-1211011886
   ✔  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/45788#pullrequestreview-1211148529
   ℹ  This PR is being fast-tracked
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-12-08T23:08:17Z: https://ci.nodejs.org/job/node-test-pull-request/48360/
- Querying data for job/node-test-pull-request/48360/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3656535524
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Dec 9, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48365/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aymen94
aymen94 approved these changes Dec 9, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Dec 10, 2022
CI Reliability 2022-12-10 nodejs/reliability#453
Open
9 tasks
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48376/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen gengjiawen added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Dec 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 10, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 894aff7 into nodejs:main Dec 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2022

Copy link
Copy Markdown
Collaborator

Landed in 894aff7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Dec 11, 2022
CI Reliability 2022-12-11 nodejs/reliability#454
Open
CI Reliability 2022-12-12 nodejs/reliability#455
Open
This was referenced Dec 13, 2022
CI Reliability 2022-12-13 nodejs/reliability#456
Open
CI Reliability 2022-12-14 nodejs/reliability#457
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@anonrig @targos
deps: V8: cherry-pick bc831f8ba33b
faee973 
Original commit message:

    [fastcall] Implement support for onebyte string arguments

    This CL adds one byte string specialization support for fast API call arguments.
    It introduces a kOneByteString variant to CTypeInfo.

    We see a ~6x improvement in Deno's TextEncoder#encode microbenchmark.
    Rendered results: https://divy-v8-patches.deno.dev/

    Bug: chromium:1052746
    Change-Id: I47c3a9e101cd18ddc6ad58f627db3a34231b60f7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4036884
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Maya Lekova <[email protected]>
    Commit-Queue: Maya Lekova <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#84552}

Refs: v8/v8@bc831f8
PR-URL: #45788
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
v19.4.0 proposal #46061
Merged
@juanarbol

juanarbol commented Jan 26, 2023

Copy link
Copy Markdown
Member

This needs manual backport to v18.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol juanarbol added the backport-requested-v18.x label Jan 26, 2023
@danielleadams danielleadams mentioned this pull request Apr 3, 2023
buffer: use v8 fast API calls for Buffer.byteLength with sequential one-byte strings #46616
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@daeyeon daeyeon daeyeon approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@anonrig @nodejs-github-bot @juanarbol @addaleax @gengjiawen @daeyeon @aymen94
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.