GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: buffer.fill empty value by marco-ippolito · Pull Request #45794 · nodejs/node

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented Dec 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Resolves: #45727
The doc is missing the case where the Buffer.fill value is empty.
I've created a test (not sure if necessary) and added the behaviour to the doc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 9, 2022
@marco-ippolito marco-ippolito changed the title doc: Buffer.fill empty value doc: buffer.fill empty value Dec 9, 2022
@marco-ippolito
doc: buffer.fill empty value
a4f383f
@marco-ippolito
marco-ippolito force-pushed the doc/buffer-fill-empty branch from 5214a83 to a4f383f Compare December 9, 2022 10:11
mscdex
mscdex reviewed Dec 9, 2022
View reviewed changes
Comment thread doc/api/buffer.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito @mscdex
doc: missing period
ca25dd3 
Co-authored-by: mscdex <[email protected]>
anonrig
anonrig approved these changes Dec 10, 2022
View reviewed changes
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 10, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48379/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShogunPanda
ShogunPanda approved these changes Dec 12, 2022
View reviewed changes

@ShogunPanda ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

And no, there are never enough tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ShogunPanda ShogunPanda added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Dec 12, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 12, 2022
@nodejs-github-bot
nodejs-github-bot merged commit c6c3eea into nodejs:main Dec 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 12, 2022

Copy link
Copy Markdown
Collaborator

Landed in c6c3eea
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Dec 12, 2022
@marco-ippolito @targos
doc: buffer.fill empty value
bb16e9f 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
@targos targos mentioned this pull request Dec 12, 2022
v19.3.0 release proposal #45831
Merged
targos pushed a commit that referenced this pull request Dec 13, 2022
@marco-ippolito @targos
doc: buffer.fill empty value
8a90f5c 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@marco-ippolito @danielleadams
doc: buffer.fill empty value
a1b25c0 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@marco-ippolito @danielleadams
doc: buffer.fill empty value
108220c 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@marco-ippolito @danielleadams
doc: buffer.fill empty value
d0513f2 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes
@anonrig anonrig anonrig approved these changes
+1 more reviewer
@mscdex mscdex mscdex left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The behavior of Buffer’s methods with an empty fill has not been documented.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@marco-ippolito @nodejs-github-bot @mscdex @ShogunPanda @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.