GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: update src/crypto/* in preparation for quic by jasnell · Pull Request #45912 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Dec 19, 2022

Copy link
Copy Markdown
Member

In preparation for use by the QUIC implementation, updates some pieces of src/crypto. These changes have been separated out of the larger quic PR (#44325) to make incremental review easier / possible.

/cc @bnoordhuis ... I've addressed the comments you had in #44325 here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, addaleax, and lin72h reacted with thumbs up emoji Qard and lin72h reacted with heart emoji
All reactions
  • 👍 3 reactions
  • ❤️ 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Dec 19, 2022
@jasnell jasnell mentioned this pull request Dec 19, 2022
src: quic #44325
Closed
@jasnell
jasnell requested review from bnoordhuis and tniessen December 19, 2022 19:52
@jasnell jasnell changed the title src: add GetCurrentCipherName/Version to crypto_common src: update src/crypto/* in preparation for quic Dec 19, 2022
@jasnell
jasnell force-pushed the quic-preparation-crypto branch from e4321c8 to 088c5f0 Compare December 19, 2022 21:31
addaleax
addaleax reviewed Dec 19, 2022
View reviewed changes
Comment thread src/crypto/crypto_context.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jasnell
jasnell force-pushed the quic-preparation-crypto branch from 37ec12f to 64778c5 Compare December 20, 2022 00:15
@jasnell
jasnell requested a review from addaleax December 20, 2022 00:15
mcollina
mcollina approved these changes Dec 20, 2022
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green CI

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bnoordhuis
bnoordhuis approved these changes Dec 20, 2022
View reviewed changes

@bnoordhuis bnoordhuis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test failures are probably because of an inverted logical check.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/crypto/crypto_context.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Dec 20, 2022
View reviewed changes
@jasnell
jasnell force-pushed the quic-preparation-crypto branch from 64778c5 to 267a482 Compare December 20, 2022 19:06
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 20, 2022
anonrig
anonrig approved these changes Dec 20, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48685/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Dec 22, 2022
CI Reliability 2022-12-22 nodejs/reliability#465
Open
14 tasks
RafaelGSS
RafaelGSS approved these changes Dec 22, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Dec 23, 2022
CI Reliability 2022-12-23 nodejs/reliability#466
Open
13 tasks
JungMinu
JungMinu approved these changes Dec 23, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48719/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Dec 24, 2022
CI Reliability 2022-12-24 nodejs/reliability#467
Open
CI Reliability 2022-12-25 nodejs/reliability#468
Open
@nodejs-github-bot

nodejs-github-bot commented Dec 25, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48730/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Dec 26, 2022
CI Reliability 2022-12-26 nodejs/reliability#469
Open
CI Reliability 2022-12-27 nodejs/reliability#470
Open
ronag
ronag approved these changes Jan 19, 2023
View reviewed changes
@ronag

ronag commented Jan 19, 2023

Copy link
Copy Markdown
Member

Is anything stopping us from landing this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Jan 20, 2023

Copy link
Copy Markdown
Member Author

Just time for me to get back to it. I'll rebase it tomorrow and do another CI run then will get it landed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 22, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49129/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tniessen
tniessen reviewed Jan 22, 2023
View reviewed changes
Comment thread src/crypto/crypto_context.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell added 3 commits January 22, 2023 14:25
@jasnell
src: add GetCurrentCipherName/Version to crypto_common
e33237b 
In preparation for use by the QUIC implementation.
@jasnell
src: add KeyObjectHandle::HasInstance
8c4bdea 
In preparation for use by the QUIC implementation.
@jasnell
src: add additional utilities to crypto::SecureContext
7b624da 
In preparation for use by the QUIC implementation.
@jasnell
jasnell force-pushed the quic-preparation-crypto branch from 267a482 to 7b624da Compare January 22, 2023 22:30
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49144/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Feb 3, 2023
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Feb 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7079158...d523bfe
coolguy284 reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot closed this Feb 3, 2023
nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2023
@jasnell @nodejs-github-bot
src: add GetCurrentCipherName/Version to crypto_common
a689c4d 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2023
@jasnell @nodejs-github-bot
src: add KeyObjectHandle::HasInstance
c33c447 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2023
@jasnell @nodejs-github-bot
src: add additional utilities to crypto::SecureContext
d523bfe 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@jasnell @MylesBorins
src: add GetCurrentCipherName/Version to crypto_common
a8a2d0e 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@jasnell @MylesBorins
src: add KeyObjectHandle::HasInstance
efc59d0 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@jasnell @MylesBorins
src: add additional utilities to crypto::SecureContext
95065c3 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
v19.7.0 proposal #46725
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@jasnell @danielleadams
src: add GetCurrentCipherName/Version to crypto_common
a639e2a 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@jasnell @danielleadams
src: add KeyObjectHandle::HasInstance
92fdb24 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@jasnell @danielleadams
src: add additional utilities to crypto::SecureContext
3aef68d 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen left review comments
@mcollina mcollina mcollina approved these changes
@bnoordhuis bnoordhuis bnoordhuis approved these changes
@anonrig anonrig anonrig approved these changes
@ronag ronag ronag approved these changes
@JungMinu JungMinu JungMinu approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@addaleax addaleax Awaiting requested review from addaleax

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@jasnell @nodejs-github-bot @aduh95 @ronag @mcollina @bnoordhuis @addaleax @anonrig @tniessen @JungMinu @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.