GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x backport] test_runner: avoid swallowing of asynchronously thrown errors by fossamagna · Pull Request #46005 · nodejs/node

Conversation

@fossamagna

@fossamagna fossamagna commented Dec 29, 2022

Copy link
Copy Markdown
Contributor

This RP is backport of #45264 to v18.x.

Refs: #45264 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot

nodejs-github-bot commented Dec 29, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 29, 2022
MoLow
MoLow approved these changes Dec 29, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48768/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Dec 31, 2022
CI Reliability 2022-12-31 nodejs/reliability#474
Open
CI Reliability 2023-01-01 nodejs/reliability#475
Open
CI Reliability 2023-01-02 nodejs/reliability#476
Open
CI Reliability 2023-01-03 nodejs/reliability#477
Open
@danielleadams
danielleadams force-pushed the v18.x-staging branch from 68cca1e to 2098d7a Compare January 3, 2023 15:48
@github-actions github-actions Bot mentioned this pull request Jan 4, 2023
CI Reliability 2023-01-04 nodejs/reliability#478
Open
20 tasks
@danielleadams
danielleadams force-pushed the v18.x-staging branch from 2098d7a to bac6b7d Compare January 4, 2023 17:10
@github-actions github-actions Bot mentioned this pull request Jan 5, 2023
CI Reliability 2023-01-05 nodejs/reliability#479
Open
22 tasks
@juanarbol

juanarbol commented Jan 22, 2023

Copy link
Copy Markdown
Member

Hey! Thanks for this patch. Would you mind rebasing this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas and others added 3 commits January 23, 2023 09:15
@legendecas @fossamagna
src: per-environment time origin value
997da3d
According to https://html.spec.whatwg.org/#environment-settings-object,
the timeOrigin is a per-environment value. Worker's timeOrigin is the
time when the worker is created.

PR-URL: nodejs#43781
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@legendecas @fossamagna
src: introduce node::Realm
299e6b4
To distinguish per-context values from the node::Environment, split
those values to a new node::Realm structure and consolidate
bootstrapping methods with it.

PR-URL: nodejs#44179
Refs: nodejs#42528
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@fossamagna
test_runner: avoid swallowing of asynchronously thrown errors
024450a
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@fossamagna
fossamagna force-pushed the backport-v18-test-runner-extraneous-async-fail branch from 6bba8f9 to 024450a Compare January 23, 2023 01:30
@fossamagna

fossamagna commented Jan 24, 2023

Copy link
Copy Markdown
Contributor Author

@juanarbol Thanks. I rebased and pushed this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 24, 2023
@MoLow MoLow mentioned this pull request Jan 26, 2023
test: fix flaky test-runner-exit-code.js #46138
Merged
@MoLow

MoLow commented Jan 26, 2023

Copy link
Copy Markdown
Member

the rebase did not seem to be successful, so I am closing in favor of #46360
please feel free to reopen if it is needed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow MoLow closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@fossamagna @nodejs-github-bot @juanarbol @MoLow @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.