GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: avoid swallowing of asynchronously thrown errors by fossamagna · Pull Request #45264 · nodejs/node

Conversation

@fossamagna

@fossamagna fossamagna commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

Fixes: #44612

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji jaydenseric reacted with eyes emoji
All reactions
  • 👍 1 reaction
  • 👀 1 reaction
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Nov 1, 2022
VoltrexKeyva
VoltrexKeyva reviewed Nov 1, 2022
View reviewed changes
Comment thread lib/internal/test_runner/harness.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow previously approved these changes Nov 1, 2022
View reviewed changes

@MoLow MoLow left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this seems to have affected test/es-module/test-esm-repl-imports.js

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MoLow
MoLow dismissed their stale review November 1, 2022 18:29

test/es-module/test-esm-repl-imports.js

@fossamagna
fossamagna requested review from MoLow and VoltrexKeyva and removed request for MoLow and VoltrexKeyva November 2, 2022 06:11
MoLow
MoLow approved these changes Nov 2, 2022
View reviewed changes
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 2, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47629/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow

MoLow commented Nov 2, 2022

Copy link
Copy Markdown
Member

CC @nodejs/test_runner an additional approval would be appreciated
benjamingr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Nov 2, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

⚠️The commit message should start with a verb – e.g. test_runner: avoid swallowing of asynchronously thrown errors.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Nov 2, 2022
View reviewed changes
@fossamagna fossamagna changed the title test_runner: extraneous async activity make a failure test_runner: avoid swallowing of asynchronously thrown errors Nov 3, 2022
@MoLow

MoLow commented Nov 7, 2022

Copy link
Copy Markdown
Member

@fossamagna can you please amend the commit message?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fossamagna
test_runner: avoid swallowing of asynchronously thrown errors
5f17453 
Fixes: nodejs#44612
@fossamagna
fossamagna force-pushed the test-runner-extraneous-async-fail branch from 79cc2f1 to 5f17453 Compare November 7, 2022 06:12
@fossamagna

fossamagna commented Nov 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@MoLow I squashed commits and amend commit message.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 7, 2022
MoLow
MoLow approved these changes Nov 7, 2022
View reviewed changes
@MoLow MoLow added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 7, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 7, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@fossamagna
fossamagna deleted the test-runner-extraneous-async-fail branch November 7, 2022 13:50
This was referenced Nov 8, 2022
CI Reliability 2022-11-08 nodejs/reliability#422
Open
CI Reliability 2022-11-09 nodejs/reliability#423
Open
@github-actions github-actions Bot mentioned this pull request Nov 10, 2022
CI Reliability 2022-11-10 nodejs/reliability#424
Open
20 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@fossamagna @RafaelGSS
test_runner: avoid swallowing of asynchronously thrown errors
920804d 
Fixes: #44612
PR-URL: #45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
v19.1.0 proposal #45269
Merged
@github-actions github-actions Bot mentioned this pull request Nov 11, 2022
CI Reliability 2022-11-11 nodejs/reliability#425
Open
19 tasks
@MoLow MoLow mentioned this pull request Nov 24, 2022
[v16.x backport] backport multiple test runner features #45602
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Dec 9, 2022
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
549b123 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams

danielleadams commented Dec 28, 2022

Copy link
Copy Markdown
Contributor

@fossamagna this broke when landing in v18.x-staging. Do you mind opening a backport PR for this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fossamagna

fossamagna commented Dec 29, 2022

Copy link
Copy Markdown
Contributor Author

@danielleadams Yes, I will open backport PR for this.
danielleadams reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fossamagna fossamagna mentioned this pull request Dec 29, 2022
[v18.x backport] test_runner: avoid swallowing of asynchronously thrown errors #46005
Closed
@danielleadams danielleadams added the backport-open-v18.x label Dec 30, 2022
fossamagna added a commit to fossamagna/node that referenced this pull request Jan 23, 2023
@fossamagna
test_runner: avoid swallowing of asynchronously thrown errors
024450a 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow MoLow mentioned this pull request Jan 26, 2023
[v18.x backport] test_runner various features #46360
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
53d8bf8 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
8eac8c3 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@fossamagna @MoLow
fix: avoid swallowing of asynchronously thrown errors
e409b25 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@fossamagna @MoLow
fix: avoid swallowing of asynchronously thrown errors
ce33670 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@fossamagna @MoLow
fix: avoid swallowing of asynchronously thrown errors
cff397a 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node that referenced this pull request Feb 25, 2023
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
9ec0a4e 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@fossamagna @juanarbol
test_runner: avoid swallowing of asynchronously thrown errors
c662025 
Fixes: #44612
PR-URL: #45264
Backport-PR-URL: #46839
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
V18.15.0 proposal #46920
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@fossamagna @juanarbol
test_runner: avoid swallowing of asynchronously thrown errors
5fdf374 
Fixes: #44612
PR-URL: #45264
Backport-PR-URL: #46839
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@MoLow MoLow MoLow approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test runner swallows uncaughtException

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@fossamagna @nodejs-github-bot @MoLow @aduh95 @danielleadams @benjamingr @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.