GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — events: check signal before listener by deokjinkim · Pull Request #46054 · nodejs/node

Conversation

@deokjinkim

@deokjinkim deokjinkim commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

In WPT Events, TypeError is expected if both listener and signal are null. But checking listener doesn't throw TypeError. So check signal before listener because checking signal throws TypeError if signal is null.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@deokjinkim
events: check signal before listener
4b38660 
In WPT Events, TypeError is expected if both listener and
signal are null. But checking listener doesn't throw TypeError.
So check signal before listener because checking signal throws
TypeError if signal is null.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 2, 2023
aduh95
aduh95 approved these changes Jan 2, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 2, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48806/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
juanarbol
juanarbol approved these changes Jan 2, 2023
View reviewed changes

@juanarbol juanarbol left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48813/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Jan 2, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jan 3, 2023
CI Reliability 2023-01-03 nodejs/reliability#477
Open
23 tasks
JungMinu
JungMinu approved these changes Jan 3, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jan 4, 2023
CI Reliability 2023-01-04 nodejs/reliability#478
Open
20 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 5d4cb84 into nodejs:main Jan 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5d4cb84
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jan 5, 2023
CI Reliability 2023-01-05 nodejs/reliability#479
Open
22 tasks
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@deokjinkim @RafaelGSS
events: check signal before listener
b5e036e 
In WPT Events, TypeError is expected if both listener and
signal are null. But checking listener doesn't throw TypeError.
So check signal before listener because checking signal throws
TypeError if signal is null.

PR-URL: nodejs#46054
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@deokjinkim @RafaelGSS
events: check signal before listener
3dcdab3 
In WPT Events, TypeError is expected if both listener and
signal are null. But checking listener doesn't throw TypeError.
So check signal before listener because checking signal throws
TypeError if signal is null.

PR-URL: #46054
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
v19.5.0 proposal #46286
Merged
@juanarbol

juanarbol commented Jan 25, 2023

Copy link
Copy Markdown
Member

This is breaking tons of tests in v18.x 💔
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol juanarbol added the backport-requested-v18.x label Jan 25, 2023
@deokjinkim

deokjinkim commented Jan 30, 2023

Copy link
Copy Markdown
Contributor Author

This is breaking tons of tests in v18.x broken_heart

@juanarbol When I try to backport this PR to v18.x-staging, then I met conflict because previous PR(#43153) which changed lib/internal/event_target.js is not landed on v18.x-staging. For this case, should I cherry-pick related all PRs together?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@JungMinu JungMinu JungMinu approved these changes
@aduh95 aduh95 aduh95 approved these changes
@juanarbol juanarbol juanarbol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@deokjinkim @nodejs-github-bot @juanarbol @lpinca @JungMinu @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.