GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc,crypto: fix WebCryptoAPI import keyData and export return by panva · Pull Request #46076 · nodejs/node

Conversation

@panva

@panva panva commented Jan 3, 2023

Copy link
Copy Markdown
Member

On the exportKey function an Object resolve is possible when keyFormat is jwk.

On the importKey function the KeyObject option was removed in #43310 and the Object option is missing and possible when the keyFormat is jwk.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@panva
doc,crypto: fix WebCryptoAPI import keyData and export return
27e041c
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation. labels Jan 3, 2023
@panva panva added the webcrypto Issues and PRs related to the Web Crypto API. label Jan 3, 2023
lpinca
lpinca approved these changes Jan 4, 2023
View reviewed changes
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 5, 2023
tniessen
tniessen approved these changes Jan 7, 2023
View reviewed changes
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 7, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jan 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 7, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/46076
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
    at consumeBody (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Response.text (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
    at async Request.json (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
    at async Request.query (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
    at async Request.queryAll (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
    at async Request.gql (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
    at async PRData.getComments (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
    at async Promise.all (index 2)
    at async Promise.all (index 1) {
  type: 'system',
  errno: 'ERR_STREAM_PREMATURE_CLOSE',
  code: 'ERR_STREAM_PREMATURE_CLOSE',
  erroredSysCall: undefined
}
https://github.com/nodejs/node/actions/runs/3861235989
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Jan 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 7, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ce1108a into nodejs:main Jan 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in ce1108a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva
panva deleted the fix-webcrypto-docs branch January 7, 2023 08:33
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@panva @RafaelGSS
doc,crypto: fix WebCryptoAPI import keyData and export return
5bc0b7d 
PR-URL: nodejs#46076
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@panva @RafaelGSS
doc,crypto: fix WebCryptoAPI import keyData and export return
b002330 
PR-URL: #46076
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
v19.5.0 proposal #46286
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@panva @juanarbol
doc,crypto: fix WebCryptoAPI import keyData and export return
5dc3cf8 
PR-URL: #46076
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
V18.14.0 proposal #46396
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@panva @juanarbol
doc,crypto: fix WebCryptoAPI import keyData and export return
ebe2921 
PR-URL: #46076
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@panva @nodejs-github-bot @lpinca @tniessen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.