GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add text around collaborative expectations by mhdawson · Pull Request #46121 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Jan 6, 2023

Copy link
Copy Markdown
Member
  • add text discussed by the TSC

Signed-off-by: Michael Dawson [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson
doc: add text around collaborative expectations
d008b7d 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Jan 6, 2023
ronag
ronag approved these changes Jan 6, 2023
View reviewed changes
GeoffreyBooth
GeoffreyBooth approved these changes Jan 6, 2023
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Jan 6, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Jan 6, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented Jan 7, 2023

Copy link
Copy Markdown
Member

Did something prompt this? The blurb has a strong "water is wet, news at 11" vibe and the README is already interminably long...

Aside: I'd be in favor of moving out the collaborators/triagers/etc. lists.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen reviewed Jan 9, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson @Trott
incorporate suggestions
51e0afd 
Co-authored-by: Rich Trott <[email protected]>
aduh95
aduh95 reviewed Jan 9, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Jan 9, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mhdawson and others added 4 commits January 9, 2023 12:30
@mhdawson @aduh95
Update README.md
66a777f 
Co-authored-by: Antoine du Hamel <[email protected]>
@mhdawson @aduh95
Update README.md
4202118 
Co-authored-by: Antoine du Hamel <[email protected]>
@mhdawson @Trott
incorporate suggestions
cc7fc16 
Co-authored-by: Rich Trott <[email protected]>
@mhdawson
incorporate suggested changes
febcd9e
@mhdawson

mhdawson commented Jan 9, 2023

Copy link
Copy Markdown
Member Author

@Trott I've incorporate all of your suggested changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ChALkeR
ChALkeR approved these changes Jan 11, 2023
View reviewed changes

@ChALkeR ChALkeR left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Would expect it below code of conduct, but that's not very signiciant.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson

mhdawson commented Jan 11, 2023

Copy link
Copy Markdown
Member Author

I think the open questions have been discussed/answered. I meant to tag the TSC at begining with @nodejs/tsc which I'm doing now so that we get more TSC review before it lands. @nodejs/tsc.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Jan 11, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gireeshpunathil
gireeshpunathil approved these changes Jan 12, 2023
View reviewed changes
RaisinTen
RaisinTen approved these changes Jan 12, 2023
View reviewed changes
BethGriggs
BethGriggs approved these changes Jan 12, 2023
View reviewed changes
aduh95
aduh95 approved these changes Jan 12, 2023
View reviewed changes
joesepi
joesepi approved these changes Jan 12, 2023
View reviewed changes
legendecas
legendecas approved these changes Jan 13, 2023
View reviewed changes
RafaelGSS
RafaelGSS approved these changes Jan 13, 2023
View reviewed changes
@mhdawson

mhdawson commented Jan 17, 2023

Copy link
Copy Markdown
Member Author

Ok going to go ahead and land.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented Jan 17, 2023

Copy link
Copy Markdown
Member Author

Landed in c62a860
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Jan 17, 2023
mhdawson added a commit that referenced this pull request Jan 17, 2023
@mhdawson
doc: add text around collaborative expectations
c62a860 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #46121
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joe Sepi <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@mhdawson @RafaelGSS
doc: add text around collaborative expectations
5e01bb9 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#46121
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joe Sepi <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@mhdawson @RafaelGSS
doc: add text around collaborative expectations
90924ce 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #46121
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joe Sepi <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
v19.5.0 proposal #46286
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@mhdawson @juanarbol
doc: add text around collaborative expectations
af04a4b 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #46121
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joe Sepi <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
V18.14.0 proposal #46396
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@mhdawson @juanarbol
doc: add text around collaborative expectations
5294371 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #46121
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joe Sepi <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@Trott Trott Trott left review comments
@mcollina mcollina mcollina approved these changes
@ChALkeR ChALkeR ChALkeR approved these changes
@ronag ronag ronag approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@legendecas legendecas legendecas approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+2 more reviewers
@mscdex mscdex mscdex left review comments
@joesepi joesepi joesepi approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

16 participants

@mhdawson @bnoordhuis @mcollina @mscdex @joesepi @ChALkeR @GeoffreyBooth @Trott @ronag @gireeshpunathil @BethGriggs @legendecas @aduh95 @RafaelGSS @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.