GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: update to match changed --dns-result-order default by tikotzky · Pull Request #46148 · nodejs/node

Conversation

@tikotzky

@tikotzky tikotzky commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

Update documentation to match the changed --dns-result-order default value in Node.js 17.

Seems like this was missed in 816e92e

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to Node.js documentation. labels Jan 9, 2023
lpinca
lpinca approved these changes Jan 9, 2023
View reviewed changes
mhdawson
mhdawson approved these changes Jan 9, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mcollina
mcollina approved these changes Jan 10, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ShogunPanda
ShogunPanda approved these changes Jan 10, 2023
View reviewed changes
cjihrig
cjihrig approved these changes Jan 10, 2023
View reviewed changes
aymen94
aymen94 approved these changes Jan 11, 2023
View reviewed changes
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 11, 2023
@mcollina

mcollina commented Jan 11, 2023

Copy link
Copy Markdown
Member

@tikotzky could you fix the commit message? This can help: https://www.npmjs.com/package/core-validate-commit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48939/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tikotzky
doc: update to match changed --dns-result-order default
42a0d76 
Update documentation to match the changed `--dns-result-order` default
value in Node.js 17.
@tikotzky
tikotzky force-pushed the patch-1 branch from b218253 to 42a0d76 Compare January 11, 2023 12:18
@tikotzky

tikotzky commented Jan 11, 2023

Copy link
Copy Markdown
Contributor Author

@mcollina thanks. I updated let me know if it looks ok now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jan 12, 2023
CI Reliability 2023-01-12 nodejs/reliability#481
Open
CI Reliability 2023-01-13 nodejs/reliability#482
Open
CI Reliability 2023-01-14 nodejs/reliability#483
Open
CI Reliability 2023-01-15 nodejs/reliability#484
Open
CI Reliability 2023-01-16 nodejs/reliability#485
Open
@aduh95
aduh95 merged commit 8986bf8 into nodejs:main Jan 16, 2023
@aduh95

aduh95 commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

Landed in 8986bf8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jan 17, 2023
CI Reliability 2023-01-17 nodejs/reliability#486
Open
17 tasks
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@tikotzky @RafaelGSS
doc: update to match changed --dns-result-order default
b776370 
Update documentation to match the changed `--dns-result-order` default
value in Node.js 17.0.0.

PR-URL: nodejs#46148
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jan 18, 2023
CI Reliability 2023-01-18 nodejs/reliability#487
Open
18 tasks
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@tikotzky @RafaelGSS
doc: update to match changed --dns-result-order default
2d32835 
Update documentation to match the changed `--dns-result-order` default
value in Node.js 17.0.0.

PR-URL: #46148
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
v19.5.0 proposal #46286
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@tikotzky @juanarbol
doc: update to match changed --dns-result-order default
133bf63 
Update documentation to match the changed `--dns-result-order` default
value in Node.js 17.0.0.

PR-URL: #46148
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
V18.14.0 proposal #46396
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@tikotzky @juanarbol
doc: update to match changed --dns-result-order default
be85d5a 
Update documentation to match the changed `--dns-result-order` default
value in Node.js 17.0.0.

PR-URL: #46148
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@ShogunPanda ShogunPanda ShogunPanda approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
+2 more reviewers
@mhdawson mhdawson mhdawson approved these changes
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@tikotzky @nodejs-github-bot @mcollina @aduh95 @ShogunPanda @lpinca @cjihrig @mhdawson @aymen94
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.