GeezerVison

- Loading data for nodejs/node/pull/46175
✔  Done loading data for nodejs/node/pull/46175
----------------------------------- PR info ------------------------------------
Title      events: change status of `event.returnvalue` to legacy (#46175)
Author     Deokjin Kim  (@deokjinkim)
Branch     deokjinkim:230112_event_returnvalue_legacy -> nodejs:main
Labels     author ready, needs-ci
Commits    3
 - events: change status of `event.returnvalue` to legacy
 - use cancelable to determine returnValue
 - revise description of `event.returnValue`
Committers 2
 - Deokjin Kim 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/46175
Refs: https://dom.spec.whatwg.org/#interface-event
Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue
Reviewed-By: James M Snell 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46175
Refs: https://dom.spec.whatwg.org/#interface-event
Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue
Reviewed-By: James M Snell 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 11 Jan 2023 23:52:53 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46175#pullrequestreview-1247085422
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46175#pullrequestreview-1251339886
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-01-17T14:45:15Z: https://ci.nodejs.org/job/node-test-pull-request/49010/
- Querying data for job/node-test-pull-request/49010/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 46175
From https://github.com/nodejs/node
 * branch                  refs/pull/46175/merge -> FETCH_HEAD
✔  Fetched commits as cf8c6994e0f7..e8262f69afbd
--------------------------------------------------------------------------------
Auto-merging doc/api/events.md
[main e10a37f04f] events: change status of `event.returnvalue` to legacy
 Author: Deokjin Kim 
 Date: Thu Jan 12 08:46:33 2023 +0900
 2 files changed, 5 insertions(+), 1 deletion(-)
[main 238bd86f97] use cancelable to determine returnValue
 Author: Deokjin Kim 
 Date: Tue Jan 17 12:21:14 2023 +0900
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging doc/api/events.md
[main 6c25c19cd3] revise description of `event.returnValue`
 Author: Deokjin Kim 
 Date: Tue Jan 17 19:05:36 2023 +0900
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)
Executing: git node land --amend --yes

⚠  Found Refs: https://dom.spec.whatwg.org/#interface-event, skipping..

⚠  Found Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue, skipping..

--------------------------------- New Message ----------------------------------

events: change status of event.returnvalue to legacy
event.returnvalue is described as legacy in spec.

Plus, add missed '#'(private member) of defaultPrevented

in implementation.
Refs: https://dom.spec.whatwg.org/#interface-event

Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue

PR-URL: #46175

Reviewed-By: James M Snell [email protected]

Reviewed-By: Antoine du Hamel [email protected]
[detached HEAD 821d73e785] events: change status of event.returnvalue to legacy

Author: Deokjin Kim [email protected]

Date: Thu Jan 12 08:46:33 2023 +0900

2 files changed, 5 insertions(+), 1 deletion(-)

Rebasing (3/6)

Rebasing (4/6)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

use cancelable to determine returnValue
Co-authored-by: Antoine du Hamel [email protected]

PR-URL: #46175

Refs: https://dom.spec.whatwg.org/#interface-event

Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue

Reviewed-By: James M Snell [email protected]

Reviewed-By: Antoine du Hamel [email protected]
[detached HEAD e9cdcbf745] use cancelable to determine returnValue

Author: Deokjin Kim [email protected]

Date: Tue Jan 17 12:21:14 2023 +0900

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (5/6)

Rebasing (6/6)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

revise description of event.returnValue
Co-authored-by: Antoine du Hamel [email protected]

PR-URL: #46175

Refs: https://dom.spec.whatwg.org/#interface-event

Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue

Reviewed-By: James M Snell [email protected]

Reviewed-By: Antoine du Hamel [email protected]
[detached HEAD 39491fc07b] revise description of event.returnValue

Author: Deokjin Kim [email protected]

Date: Tue Jan 17 19:05:36 2023 +0900

1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.