GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: https update default request timeout by marco-ippolito · Pull Request #46184 · nodejs/node

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented Jan 12, 2023

Copy link
Copy Markdown
Member

from: #41263
I updated the default value on https doc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@marco-ippolito
doc: https update default request timeout
e5243b4
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. https Issues and PRs related to the https subsystem. labels Jan 12, 2023
ShogunPanda
ShogunPanda reviewed Jan 12, 2023
View reviewed changes
Comment thread doc/api/https.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito
doc: changed version to 18
20d3250
aduh95
aduh95 reviewed Jan 12, 2023
View reviewed changes
Comment thread doc/api/https.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito @aduh95
doc: typo
e8acbb5 
Co-authored-by: Antoine du Hamel <[email protected]>
ShogunPanda
ShogunPanda approved these changes Jan 12, 2023
View reviewed changes

@ShogunPanda ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
richardlau
richardlau approved these changes Jan 12, 2023
View reviewed changes
@richardlau richardlau added dont-land-on-v14.x labels Jan 12, 2023
anonrig
anonrig approved these changes Jan 12, 2023
View reviewed changes
lpinca
lpinca approved these changes Jan 12, 2023
View reviewed changes
jasnell
jasnell approved these changes Jan 13, 2023
View reviewed changes
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 13, 2023
@github-actions

github-actions Bot commented Jan 13, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.
lpinca, ShogunPanda, and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Jan 13, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Jan 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 13, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 1f31eb2 into nodejs:main Jan 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1f31eb2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@marco-ippolito @RafaelGSS
doc: https update default request timeout
6fb841e 
PR-URL: nodejs#46184
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@marco-ippolito @RafaelGSS
doc: https update default request timeout
1b45713 
PR-URL: #46184
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
v19.5.0 proposal #46286
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@marco-ippolito @juanarbol
doc: https update default request timeout
fdd5fa4 
PR-URL: #46184
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
V18.14.0 proposal #46396
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@marco-ippolito @juanarbol
doc: https update default request timeout
e54483c 
PR-URL: #46184
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. https Issues and PRs related to the https subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@marco-ippolito @nodejs-github-bot @ShogunPanda @jasnell @lpinca @anonrig @richardlau @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.