GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x backport] stream: streams and webstreams interop related changes by debadree25 · Pull Request #46314 · nodejs/node

Conversation

@debadree25

@debadree25 debadree25 commented Jan 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Backports the following PRs:
#46190
#46273
#46307
#46312
#46315
#46403
#46600
#46675

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v18.x web streams Issues and PRs related to the Web Streams API. labels Jan 23, 2023
@debadree25

debadree25 commented Jan 23, 2023

Copy link
Copy Markdown
Contributor Author

cc @aduh95
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Jan 23, 2023

Copy link
Copy Markdown
Contributor

We need to wait on #46312 to land first, and backport the three PRs in one backport PR (i.e. you need to cherry-pick the two other commits onto this branch). I'm going to convert this to draft if that's OK as this can't happen until #46312 lands.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 marked this pull request as draft January 23, 2023 13:29
@debadree25

debadree25 commented Jan 23, 2023

Copy link
Copy Markdown
Contributor Author

Sure no issue!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25

debadree25 commented Jan 23, 2023

Copy link
Copy Markdown
Contributor Author

So overall would need to cherry-pick #46205, #46190, #46315 and #46312 into this single PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol
juanarbol force-pushed the v18.x-staging branch from 7351221 to fcfde34 Compare January 31, 2023 13:17
@debadree25

debadree25 commented Feb 27, 2023

Copy link
Copy Markdown
Contributor Author

Hi @aduh95 all the streams related changes have landed, should i open a fresh backport PR including all the changes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Feb 27, 2023

Copy link
Copy Markdown
Contributor

You can keep this PR, you just need to push the other commits to your backport-46205-to-v18.x branch.
debadree25 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25 debadree25 closed this Feb 27, 2023
@debadree25
debadree25 force-pushed the backport-46205-to-v18.x branch from 7902a99 to b266adb Compare February 27, 2023 09:48
@debadree25 debadree25 reopened this Feb 27, 2023
@debadree25 debadree25 changed the title [v18.x backport] stream: implement finished() for ReadableStream and WritableStream [v18.x backport] stream: streams and webstreams interop related changes Feb 27, 2023
@debadree25
debadree25 force-pushed the backport-46205-to-v18.x branch from 7204237 to f27c29c Compare February 27, 2023 10:17
debadree25
debadree25 commented Feb 27, 2023
View reviewed changes
Comment thread doc/api/stream.md Outdated

@debadree25 debadree25 Feb 27, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was release in #46396 hence added the version here

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@debadree25
debadree25 force-pushed the backport-46205-to-v18.x branch from f27c29c to 8f10c66 Compare February 27, 2023 10:23
@debadree25

debadree25 commented Feb 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Does this look ok @aduh95 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25
debadree25 marked this pull request as ready for review February 28, 2023 10:00
@juanarbol
juanarbol force-pushed the v18.x-staging branch from e17d857 to de64315 Compare March 5, 2023 04:04
@mshima mshima mentioned this pull request Mar 11, 2023
Node v18.14.0 breaks jhipster jhipster/generator-jhipster#21380
Closed
1 task
@debadree25
debadree25 requested a review from aduh95 March 12, 2023 11:12
@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50833/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams

danielleadams commented May 17, 2023

Copy link
Copy Markdown
Contributor

@debadree25 are you able to rebase this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25

debadree25 commented May 17, 2023

Copy link
Copy Markdown
Contributor Author

Sure will rebase this!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
debadree25 added 3 commits May 24, 2023 01:10
@debadree25
lib: add webstreams to Duplex.from()
2c1a619 
Refs: nodejs#39519
PR-URL: nodejs#46190
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
@debadree25
doc: include webstreams in finished() and Duplex.from() parameters
631afeb 
PR-URL: nodejs#46312
Refs: nodejs#46190
Refs: nodejs#46205
Reviewed-By: Antoine du Hamel <[email protected]>
@debadree25
stream: remove brandchecks from stream duplexify
0291981 
Refs: nodejs#46190
Refs: nodejs#46205 (comment)
PR-URL: nodejs#46315
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@debadree25
debadree25 force-pushed the backport-46205-to-v18.x branch from 8f10c66 to 0291981 Compare May 23, 2023 19:41
@debadree25

debadree25 commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

Hey @danielleadams rebased this, is it ok?
So sorry for the delay 😅😅😅
danielleadams reacted with thumbs up emoji danielleadams reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25
debadree25 requested a review from danielleadams May 23, 2023 19:42
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 23, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 23, 2023
@nodejs-github-bot

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51943/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 24, 2023
CI Reliability 2023-05-24 nodejs/reliability#575
Open
CI Reliability 2023-05-25 nodejs/reliability#576
Open
CI Reliability 2023-05-26 nodejs/reliability#577
Open
CI Reliability 2023-05-27 nodejs/reliability#578
Open
CI Reliability 2023-05-28 nodejs/reliability#579
Open
@nodejs-github-bot

nodejs-github-bot commented May 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51988/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request May 29, 2023
CI Reliability 2023-05-29 nodejs/reliability#580
Open
22 tasks
danielleadams
danielleadams approved these changes May 29, 2023
View reviewed changes
danielleadams pushed a commit that referenced this pull request May 29, 2023
@debadree25 @danielleadams
lib: add webstreams to Duplex.from()
d449b73 
Refs: #39519
PR-URL: #46190
Backport-PR-URL: #46314
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
danielleadams pushed a commit that referenced this pull request May 29, 2023
@debadree25 @danielleadams
doc: include webstreams in finished() and Duplex.from() parameters
402c1a3 
PR-URL: #46312
Backport-PR-URL: #46314
Refs: #46190
Refs: #46205
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request May 29, 2023
@debadree25 @danielleadams
stream: remove brandchecks from stream duplexify
e8b5a61 
Refs: #46190
Refs: #46205 (comment)
PR-URL: #46315
Backport-PR-URL: #46314
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@danielleadams

danielleadams commented May 29, 2023

Copy link
Copy Markdown
Contributor

Landed in 0b92035...e8b5a61
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams danielleadams closed this May 29, 2023
This was referenced May 30, 2023
CI Reliability 2023-05-30 nodejs/reliability#581
Open
CI Reliability 2023-05-31 nodejs/reliability#582
Open
@mshima mshima mentioned this pull request May 31, 2023
support any node 18 lts jhipster/generator-jhipster#22372
Merged
6 tasks
aduh95 pushed a commit to aduh95/node that referenced this pull request Feb 18, 2025
@debadree25 @RafaelGSS
lib: add webstreams to Duplex.from()
3658abe 
Refs: nodejs#39519
PR-URL: nodejs#46190
Backport-PR-URL: nodejs#46314
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Feb 18, 2025
@debadree25 @RafaelGSS
doc: include webstreams in finished() and Duplex.from() parameters
230a984 
PR-URL: nodejs#46312
Backport-PR-URL: nodejs#46314
Refs: nodejs#46190
Refs: nodejs#46205
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Feb 18, 2025
@debadree25 @RafaelGSS
stream: remove brandchecks from stream duplexify
cfb18d8 
Refs: nodejs#46190
Refs: nodejs#46205 (comment)
PR-URL: nodejs#46315
Backport-PR-URL: nodejs#46314
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 Awaiting requested review from aduh95
1 more reviewer
@danielleadams danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@debadree25 @nodejs-github-bot @aduh95 @danielleadams @panva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.