GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: make more crypto tests work with BoringSSL by codebytere · Pull Request #46429 · nodejs/node

Conversation

@codebytere

@codebytere codebytere commented Jan 30, 2023

Copy link
Copy Markdown
Member

This PR tweaks several crypto tests to work with BoringSSL so that Electron does not need to disable them and can smoke test our embedded Node.js executable with them.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@codebytere codebytere changed the title test: tweak several tests to work with BoringSSL test: tweak several crypto tests to work with BoringSSL Jan 30, 2023
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jan 30, 2023
@codebytere
test: make more crypto tests work with BoringSSL
27c98b7
@codebytere codebytere changed the title test: tweak several crypto tests to work with BoringSSL test: make more crypto tests work with BoringSSL Jan 30, 2023
@codebytere
codebytere force-pushed the tests-for-boringssl branch from b7574c9 to 27c98b7 Compare January 30, 2023 19:48
lpinca
lpinca approved these changes Jan 30, 2023
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 30, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 30, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
panva
panva approved these changes Jan 30, 2023
View reviewed changes
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 30, 2023
jasnell
jasnell approved these changes Jan 31, 2023
View reviewed changes
@tony-go

tony-go commented Jan 31, 2023

Copy link
Copy Markdown
Member

@dsanders11 @RaisinTen
dsanders11 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tony-go
tony-go approved these changes Jan 31, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49275/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49279/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codebytere codebytere added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 1, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 8e42d8c into nodejs:main Feb 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8e42d8c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@codebytere @MylesBorins
test: make more crypto tests work with BoringSSL
d556ccd 
PR-URL: #46429
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
v19.7.0 proposal #46725
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@codebytere @danielleadams
test: make more crypto tests work with BoringSSL
534562f 
PR-URL: #46429
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
+1 more reviewer
@tony-go tony-go tony-go approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@codebytere @nodejs-github-bot @tony-go @panva @jasnell @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.