GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: back snapshot I/O with a std::vector sink by joyeecheung · Pull Request #46463 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Feb 1, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax and bricss reacted with rocket emoji
All reactions
  • 🚀 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 1, 2023
@joyeecheung
src: back snapshot I/O with a std::vector sink
d21be77
@joyeecheung
joyeecheung force-pushed the snapshot-io branch from 3748eb0 to d21be77 Compare February 1, 2023 12:08
@nodejs-github-bot

nodejs-github-bot commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49293/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Feb 1, 2023
View reviewed changes
Comment thread src/node_snapshotable.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax mentioned this pull request Feb 1, 2023
src: add snapshot support for embedder API #45888
Closed
@nodejs-github-bot

nodejs-github-bot commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49297/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis approved these changes Feb 2, 2023
View reviewed changes
Comment thread src/node_snapshotable.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/node_snapshotable.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/node_snapshotable.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Feb 3, 2023
View reviewed changes
@joyeecheung
fixup! src: back snapshot I/O with a std::vector sink
1bc6a14
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49328/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen approved these changes Feb 3, 2023
View reviewed changes
legendecas
legendecas approved these changes Feb 3, 2023
View reviewed changes
@addaleax addaleax added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Feb 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 3, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a466fea into nodejs:main Feb 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in a466fea
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax mentioned this pull request Feb 4, 2023
src: allow blobs in addition to FILE*s in embedder snapshot API #46491
Merged
tniessen added a commit to tniessen/node that referenced this pull request Feb 4, 2023
@tniessen
src: check return value of ftell()
f60ad96 
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1)
to the vector allocator and fread().

Refs: nodejs#46463
@tniessen tniessen mentioned this pull request Feb 4, 2023
src: check return value of ftell() #46495
Merged
@github-actions github-actions Bot mentioned this pull request Feb 5, 2023
CI Reliability 2023-02-05 nodejs/reliability#495
Open
22 tasks
nodejs-github-bot pushed a commit that referenced this pull request Feb 6, 2023
@tniessen
src: check return value of ftell()
1e9ca45 
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1)
to the vector allocator and fread().

Refs: #46463
PR-URL: #46495
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Feb 6, 2023
@addaleax
src: allow blobs in addition to FILE*s in embedder snapshot API
d592630 
This is a shared follow-up to 06bb6b4 and a466fea
now that both have been merged.

PR-URL: #46491
Refs: #45888
Refs: #46463
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@joyeecheung @MylesBorins
src: back snapshot I/O with a std::vector sink
6cf860d 
PR-URL: #46463
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@tniessen @MylesBorins
src: check return value of ftell()
1a808a4 
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1)
to the vector allocator and fread().

Refs: #46463
PR-URL: #46495
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@addaleax @MylesBorins
src: allow blobs in addition to FILE*s in embedder snapshot API
c34bac2 
This is a shared follow-up to 06bb6b4 and a466fea
now that both have been merged.

PR-URL: #46491
Refs: #45888
Refs: #46463
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
v19.7.0 proposal #46725
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@joyeecheung @danielleadams
src: back snapshot I/O with a std::vector sink
8dfa748 
PR-URL: #46463
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@tniessen @danielleadams
src: check return value of ftell()
bc9a577 
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1)
to the vector allocator and fread().

Refs: #46463
PR-URL: #46495
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@bnoordhuis bnoordhuis bnoordhuis approved these changes
@jasnell jasnell jasnell approved these changes
@legendecas legendecas legendecas approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@joyeecheung @nodejs-github-bot @bnoordhuis @jasnell @addaleax @legendecas @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.